maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bentmann (JIRA)" <j...@codehaus.org>
Subject [jira] Updated: (MNG-3641) Lack of error checks on profiles
Date Wed, 04 Mar 2009 10:01:13 GMT

     [ http://jira.codehaus.org/browse/MNG-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benjamin Bentmann updated MNG-3641:
-----------------------------------

    Attachment: mng-3641.zip

This might need some more love: The current approach produces a lot of warnings during a multi-module
buid, namely one per each module that does not contain a profile. See the attached demo project
(run "mvn validate -P test") or one of the core bootstrap jobs on Hudson that run with the
profile "run-its" which is only present in one of the modules, leaving about fifty warnings
about profile activation around.

While I don't have objections to a warning per module, their placement is the log output appears
suboptimal. Right now, the warnings appear right at the start, even before the reactor build
order, so outside of any context that might be helpful for a user to associate the warning
with the module that caused it. Also, given the verbosity of Maven's log, the warnings are
easily overlooked when printed first instead of say at the end of a module build.

> Lack of error checks on profiles
> --------------------------------
>
>                 Key: MNG-3641
>                 URL: http://jira.codehaus.org/browse/MNG-3641
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Profiles
>    Affects Versions: 2.0.9
>            Reporter: Kohsuke Kawaguchi
>            Assignee: Brett Porter
>             Fix For: 2.0.11, 2.1.0
>
>         Attachments: MNG-3641-IT.tar.gz, MNG-3641-maven-project.patch, mng-3641.zip
>
>
> DefaultProfileManager performs no error checks on the profile IDs So If I specify bogus
profile IDs from plugins (like {{mvn -P no-such-profile}}), Maven doesn't complain, and it
just runs as if nothing was specified. This is very error prone.
> Also, I've seen some documentation that says deactivating a profile is "-P !profile".
As far as I can tell from the code, this is wrong, but because of the lack of error check,
such usage just gets ignored, and the user is left confused as to why the profile isn't deactivated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message