maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Makeev (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MSHARED-78) FilteringUtils escapeWindowsPath() doesn't work on Windows
Date Thu, 19 Mar 2009 15:51:12 GMT

    [ http://jira.codehaus.org/browse/MSHARED-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170311#action_170311
] 

Anton Makeev commented on MSHARED-78:
-------------------------------------

I reckon not only the windows paths should be escaped, but all the properties filtered.

For example, if I have a property defined as <myValue>xxx\yyy:zzz<myValue> it
will be read from the *.properties file incorrectly as well.

Thanks,
Anton Makeev


> FilteringUtils escapeWindowsPath() doesn't work on Windows
> ----------------------------------------------------------
>
>                 Key: MSHARED-78
>                 URL: http://jira.codehaus.org/browse/MSHARED-78
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-filtering
>    Affects Versions: maven-filtering-1.0-beta-2
>            Reporter: Marvin Froeder
>            Assignee: Olivier Lamy
>             Fix For: maven-filtering-1.0-beta-4
>
>         Attachments: filtering.patch, FilteringUtilsTest.java
>
>
> The method escapeWindowsPath() is replacing  colon by backslash + colon.
> I.e.
> D:\temp
> is escaped as
> D\:\\temp
> But windows doesn't recognize that.  If you try to open D\:\\temp on explorer, will not
work.
> Even java.io.File is not able to handle that too.  The attached test proves it.
> I'm not sure why this backslash was add to colon, but commenting line 44 of org.apache.maven.shared.filtering.FilteringUtils
make the test work.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message