maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerome Lacoste (JIRA)" <>
Subject [jira] Commented: (MECLIPSE-156) Plugin should support setting file encoding
Date Tue, 03 Nov 2009 16:48:55 GMT


Jerome Lacoste commented on MECLIPSE-156:

I was reading the code to try to fix another issue and there seems to be an issue with the
latest commit

in particular

1. the check of this value shouldn't be made in the method, but probably in  getCompilerSourceEncoding()

2. the return of getProperty() should be used.

I attach a patch that is completely untested !

> Plugin should support setting file encoding
> -------------------------------------------
>                 Key: MECLIPSE-156
>                 URL:
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: New Feature
>            Reporter: Ralph Poellath
>            Assignee: nicolas de loof
>             Fix For: 2.8
>         Attachments: maven-eclipse-plugin-2.5.1.tar.gz, MECLIPSE-156-maven-eclipse-plugin.patch,
> The plugin should support setting Eclipse's text file encoding on a per-project basis.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message