maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriele Columbro (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MCHANGES-145) Error when trying to send email for multi-module projects
Date Sat, 07 Nov 2009 13:20:55 GMT

    [ http://jira.codehaus.org/browse/MCHANGES-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197555#action_197555
] 

Gabriele Columbro commented on MCHANGES-145:
--------------------------------------------

I implemented and tested the specified "aggregate" behavior and it definitely works, and at
least I can use the maven-changes-plugin in my multimodule releases.

Still, sounds like a workaround as I'd like to be able to send an announcement for each and
every of my submodules.

Once/if this workaround is committed, I suggest to open a related issue for an improvement
in the multimodule behavior of the changes plugin.

WDYT?

> Error when trying to send email for multi-module projects
> ---------------------------------------------------------
>
>                 Key: MCHANGES-145
>                 URL: http://jira.codehaus.org/browse/MCHANGES-145
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Bug
>          Components: announcement
>    Affects Versions: 2.1
>         Environment: maven 2.0.9
> JDK 1.6.011
> WinXP
>            Reporter: Jean-Paul GUIGUI
>         Attachments: MCHANGES-145.patch
>
>
> If the pom.xml is containing some sub-modules, the goal changes:announcement-mail is
trying to send it for each module, and fail because it could not find the template.
>    Announcement template C:\Dev\MyProject\SubmoduleA\target\announcement\announcement.vm
not found...
> Should be possible to configure the pom to send only the email for the root project.
> Working with "mvn --non-recursive" option, but we need to be able to configure this behaviour
into the pom.xml 
> The same issue for the changes:announcement-generate, but it's only a warning and the
build can finish successfully.
> Should include something like:
> 	/**
> 	 * @parameter expression="${project}"
> 	 **/
> 	private MavenProject          mavenProject;
> 	/**
> 	 * If true, will generate the changes only for the root module in case of project with
sub-modules.
> 	 * 
> 	 * @parameter expression="${plugin.aggregate}" default-value = "false"
> 	 */
> 	private boolean               aggregate;
> public void execute() {
> 			if (!mavenProject.isExecutionRoot() && aggregate) {
> 				// Execute only for the main module in case of project with sub-modules
> 				return;
> 			}
>                        ..................
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message