maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Röthenbacher (JIRA) <j...@codehaus.org>
Subject [jira] Commented: (MCHECKSTYLE-134) suppressionsFileExpression does not work - cannot initialize module SuppressionFilter
Date Tue, 09 Mar 2010 22:12:55 GMT

    [ http://jira.codehaus.org/browse/MCHECKSTYLE-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213248#action_213248
] 

Felix Röthenbacher commented on MCHECKSTYLE-134:
------------------------------------------------

The bug is in class DefaultCheckstyleExecutor in method

private Properties getOverridingProperties( CheckstyleExecutorRequest request )

<...>

        if ( request.getSuppressionsFileExpression() != null )
        {
            String suppresionFile = request.getSuppressionsFileExpression();

            if ( suppresionFile != null )
            {
                p.setProperty( request.getSuppressionsFileExpression(), suppresionFile );
            }
        }

<...>

This should be

            String suppressionFile = request.getSuppressionsLocation();

            if ( suppressionFile != null )
            {
                p.setProperty( request.getSuppressionsFileExpression(), suppressionFile );
            }


> suppressionsFileExpression does not work - cannot initialize module SuppressionFilter
> -------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-134
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-134
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Felix Röthenbacher
>
> Setting the checkstyle.suppressions.file property through suppressionsFileExpression
doesn't work:
>             <configuration>
>               <configLocation>${project.build.directory}/checkstyle/checkstyle.xml</configLocation>
>               <suppressionsLocation>${project.build.directory}/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
>               <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
>             </configuration>
> Output:
> [INFO] Failed during checkstyle configuration                                       
                                                                                         
                        
> Embedded error: cannot initialize module SuppressionFilter - Cannot set property 'file'
in module SuppressionFilter to 'checkstyle.suppressions.file': unable to find checkstyle.suppressions.file
> checkstyle.suppressions.file (No such file or directory)
> -----
> Workaround:
> Using a different property name for suppressionsFileExpression and setting property manually
works though:
>             <configuration>
>               <configLocation>${project.build.directory}/checkstyle/checkstyle.xml</configLocation>
>               <suppressionsLocation>${project.build.directory}/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
>               <suppressionsFileExpression>checkstyle.suppressions.file.donothing</suppressionsFileExpression>
>               <propertyExpansion>checkstyle.suppressions.file=${project.build.directory}/checkstyle/checkstyle-suppressions.xml</propertyExpansion>
>             </configuration>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message