From issues-return-64193-apmail-maven-issues-archive=maven.apache.org@maven.apache.org Mon Jun 28 13:28:32 2010 Return-Path: Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: (qmail 80817 invoked from network); 28 Jun 2010 13:28:31 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Jun 2010 13:28:31 -0000 Received: (qmail 86940 invoked by uid 500); 28 Jun 2010 13:28:31 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 86841 invoked by uid 500); 28 Jun 2010 13:28:29 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 86828 invoked by uid 99); 28 Jun 2010 13:28:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jun 2010 13:28:29 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com) (63.246.2.115) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jun 2010 13:28:23 +0000 Received: from codehaus01.managed.contegix.com (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id 8045014A801F for ; Mon, 28 Jun 2010 08:27:32 -0500 (CDT) Date: Mon, 28 Jun 2010 08:27:32 -0500 (CDT) From: "Thom Nichols (JIRA)" To: issues@maven.apache.org Message-ID: <27979692.505.1277731652491.JavaMail.haus-jira@codehaus01.managed.contegix.com> In-Reply-To: <5360792.55921.1277460072410.JavaMail.haus-jira@codehaus01.managed.contegix.com> Subject: [jira] Commented: (DOXIA-397) Cannot link to javadoc methods MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 4e90ceb663894a42f12c0e28abbab431 X-Virus-Checked: Checked by ClamAV on apache.org [ http://jira.codehaus.org/browse/DOXIA-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=226562#action_226562 ] Thom Nichols commented on DOXIA-397: ------------------------------------ bq. It is assumed that site builders have control over both target ids and links for internal and local links, ie if Doxia fixes an invalid id, the developer should be forced to fix the link and avoid the warning. But the _developer_ isn't being forced to fix the link, Doxia is attempting to fix it for me (and breaking it in the process.) I think you mean, if Doxia fixes the link, the developer will be forced to fix the anchor that it points to? bq. Unfortunately this is not possible for auto-generated docs that produce invalid anchors/links, like javadoc. But even if I properly escape the link, Doxia still munges it. I don't think this has anything to do with the fact that Javadoc leaves unescaped characters in the URI. A valid URI like: {noformat} {{{../apidocs/groovyx/net/http/HTTPBuilder.html#defaultSuccessHandler%28org.apache.http.HttpResponse%2C%20java.lang.Object%29}defaultSuccessHandler}} {noformat} is still getting smashed by Doxia. I apologize for being dense, as I feel like keep asking the same question. But the above link -- you said it cannot be a Doxia ID. OK! So if it's not a Doxia ID, then it must be a relative URI, right? So if it's a relative URI, why would Doxia ever try to manipulate it? And if it _does_ feel the need to manipulate a "non Doxia ID" link, shouldn't it just be doing normal URI escaping like replacing " " with "%20"? But instead it appears that the "Doxia ID" rules (converting spaces to underscores and removing characters like '%') are being applied to links that are clearly relative URIs. I guess I fail to understand what the intended goal is in this case. Can't the logic be "If I see what appears to be a Doxia ID, perform the Doxia link/anchor manipulation." "If I see a link that's _not_ a Doxia ID, just apply URI-escaping rules." A link like "{{{Some Section Heading}blah}}" is clearly a Doxia ID, so don't change any of the current behavior in that case and preserve backward compatibility. > Cannot link to javadoc methods > ------------------------------ > > Key: DOXIA-397 > URL: http://jira.codehaus.org/browse/DOXIA-397 > Project: Maven Doxia > Issue Type: Bug > Components: Core, Module - Apt, Module - Xdoc > Affects Versions: 1.1.3 > Reporter: Lukas Theussl > > Using a link to a javadoc method like > {noformat} > {{{../apidocs/groovyx/net/http/ParserRegistry.html#parseText(org.apache.http.HttpResponse)}ParserRegistry}} > {noformat} > the apt parser removes the brackets of the anchor. The same thing happens with xdocs and probably other formats. Note that non-ascii characters are not legal in anchor names, but they should be replaced by their hex values, see http://www.w3.org/TR/html401/appendix/notes.html#non-ascii-chars. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira