maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bentmann (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MSHADE-84) added support for minijar'ing
Date Fri, 06 Aug 2010 09:07:32 GMT

    [ http://jira.codehaus.org/browse/MSHADE-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231172#action_231172
] 

Benjamin Bentmann commented on MSHADE-84:
-----------------------------------------

Nice, some comments/questions:
* Can you reformat the code to follow the [Maven code style|http://maven.apache.org/developers/conventions/code.html]?
* When/where are the file input streams opened by the new filter closed?

> added support for minijar'ing
> -----------------------------
>
>                 Key: MSHADE-84
>                 URL: http://jira.codehaus.org/browse/MSHADE-84
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.3.4
>            Reporter: Torsten Curdt
>         Attachments: minijar.diff
>
>
> http://github.com/tcurdt/maven-plugins/commit/5ac23b358b15ed315c871a3b8cb3301a86802a8d
> just set "minimizeJar" to "true" in the configuration to strip unused classes

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message