maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brett Porter (JIRA)" <j...@codehaus.org>
Subject [jira] Closed: (MRELEASE-350) Option '0' for "specify the selection number ( 0:All 1:Project Dependencies 2:Plugins 3:Reports 4:Extensions ):" is broken
Date Tue, 28 Sep 2010 15:57:33 GMT

     [ http://jira.codehaus.org/browse/MRELEASE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brett Porter closed MRELEASE-350.
---------------------------------

    Resolution: Fixed
      Assignee: Brett Porter

I'm not sure why the patch separated the class into two, and it was hard to read/apply with
the additional formatting changes.

I've fixed the issue and added tests - you'll see from the commit r1002231 that a much simpler
solution was possible.

Please let me know if I missed something you intended to do in addition!

> Option '0' for "specify the selection number ( 0:All 1:Project Dependencies 2:Plugins
3:Reports 4:Extensions ):" is broken
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-350
>                 URL: http://jira.codehaus.org/browse/MRELEASE-350
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-8
>            Reporter: Craig
>            Assignee: Brett Porter
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: MRELEASE-350.patch
>
>
> CheckDependencySnapshotsPhase.java has a bug when processing this prompt with the 0 option
selected:
> specify the selection number ( 0:All 1:Project Dependencies 2:Plugins 3:Reports 4:Extensions
): 0
> When choosing 0: All, the plugin goes through the motions of asking to resolve snapshot
dependencies, but after resolving them, fails saying there are still snapshot dependencies.
> This bug lies with the function resolveSnapshots relying on the function processSnapshot
to remove resolved dependencies from the set. This works for all cases except 0, which creates
a new dependency set 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message