maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brett Porter (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MRELEASE-564) Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin configuration
Date Tue, 28 Sep 2010 13:58:32 GMT

    [ http://jira.codehaus.org/browse/MRELEASE-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236728#action_236728
] 

Brett Porter commented on MRELEASE-564:
---------------------------------------

This isn't really about reading another plugin's config - in the release plugin's case, it
reads and processes the entire POM as a file, not part of the current build. So I think this
is ok - but you'll need to come up with a sensible way to detect it without hitting any false
positives.

> Fail the release when a -SNAPSHOT version is detected inside maven-remote-resources-plugin
configuration
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-564
>                 URL: http://jira.codehaus.org/browse/MRELEASE-564
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>            Reporter: Baptiste MATHUS
>            Priority: Critical
>
> Recently, I realized we rolled a released containing a reference onto a -SNAPSHOT version
of our quality rules :/.
> This was because of the following remote-resources plugin configuration:
> {code:xml}
> <plugin>
>   <artifactId>maven-remote-resources-plugin</artifactId>
>   <version>1.1</version>
>   <executions>
>     <execution>
>       <goals>
>         <goal>process</goal>
>       </goals>
>       <configuration>
>         <resourceBundles>
>           <resourceBundle>fr.comp-shared-resources:1.0-SNAPSHOT</resourceBundle>
>         </resourceBundles>
>       </configuration>
>     </execution>
>   </executions>
> </plugin>
> {code}
> I think release:prepare should fail when it detects this.
> I seem to remember it's a bad practice to read other plugin's config, but I file this
issue because:
> * remote-resources-plugin is a standard maven plugin, so I guess this use is to be often
encountered
> * this is a very important issue and I'd like to file it somewhere. Please let me know
if I should file or discuss it somewhere else.
> Cheers

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message