maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Lundberg (JIRA)" <>
Subject [jira] Commented: (DOXIASITETOOLS-40) List of site locales should be available in the rendering context.
Date Wed, 01 Dec 2010 18:01:03 GMT


Dennis Lundberg commented on DOXIASITETOOLS-40:

I had a look at your patch and have a question.

You have added this code:

    public void addSiteLocales(List locales) {

Wouldn't it be better to have this instead?

    public void setSiteLocales(List locales) {
        siteLocales = Collections.unmodifiableList( locales );

When you work on implementing the "locale switcher", keep in mind that it's a bad idea to
use images of flags to represent languages. You mentioned adding images in your previous comment.

> List of site locales should be available in the rendering context.
> ------------------------------------------------------------------
>                 Key: DOXIASITETOOLS-40
>                 URL:
>             Project: Maven Doxia Sitetools
>          Issue Type: Improvement
>          Components: Site renderer
>    Affects Versions: 1.1.4
>            Reporter: Yevgeny Nyden
>         Attachments: siteLocalesChange-sitetools.diff
> Attached is a small improvement that adds a list of available site locales to the site
rendering context. This would make a site template be "aware" of other locales available for
the site and make it possible to implement a locale switching option.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message