maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Whittemore (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MRELEASE-645) Allow File/Directory Patterns for the checkModificationExcludes Option
Date Sun, 27 Feb 2011 22:31:22 GMT

    [ http://jira.codehaus.org/browse/MRELEASE-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257913#action_257913
] 

Mike Whittemore commented on MRELEASE-645:
------------------------------------------

I would very much like to see the suggested improvements. Plus they would make this plugin's
configuration consistent with most other plugins.

> Allow File/Directory Patterns for the checkModificationExcludes Option
> ----------------------------------------------------------------------
>
>                 Key: MRELEASE-645
>                 URL: http://jira.codehaus.org/browse/MRELEASE-645
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>          Components: branch, prepare, scm
>    Affects Versions: 2.1
>         Environment: all
>            Reporter: Stefan Ferstl
>            Priority: Minor
>         Attachments: modification-excludes.patch
>
>
> The {{checkModificationExcludes}} option does currently only allow the definition single
files to be excluded from the SCM modification check. If this option is defined, all files
anywhere in the maven project structure with the specified name will be excluded from the
check. It is currently not possible to exclude files only within a specific directory or to
exclude classes of files, i.e. all files matching a specific file name pattern.
> If the {{checkModificationExcludes}} option allowed the definition of file and directory
patterns, these things would be possible.
> *Example 1*: I'd like to exclude a test resource {{src/test/resources/foo.properties}}
from the modification check but the real foo.properties in {{src/main/resources}} should still
be checked.
> {code:xml} 
> <checkModificationExcludes>
>   <checkModificationExclude>src/test/resources/foo.properties</checkModificationExclude>
> </checkModificationExcludes>
> {code}
> *Example 2*: I'd like to exclude all properties files with the prefix {{bar}} from the
modification check:
> {code:xml} 
> <checkModificationExcludes>
>   <checkModificationExclude>**/bar*.properties</checkModificationExclude>
> </checkModificationExcludes>
> {code}
> The attached patch modifies the {{ScmCheckModificationsPhase}} to use the {{DirectoryScanner}}
from plexus-utils instead of doing a strict file name comparison. The patch does not provide
more unit tests for this feature but it adjusts the existing tests to run without any failures.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message