maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Combs (JIRA)" <j...@codehaus.org>
Subject [jira] Updated: (MASSEMBLY-554) DependencySet unpackOptions 'filtered' causes unpack not to work
Date Thu, 31 Mar 2011 21:27:22 GMT

     [ http://jira.codehaus.org/browse/MASSEMBLY-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dave Combs updated MASSEMBLY-554:
---------------------------------

    Attachment: example.zip

To reproduce the bug, unzip this file.  You will have two maven projects (com.kaazing.gateway.fake1
and com.kaazing.gateway.fake2).  Run 'mvn install' on fake1.  Run 'mvn install' on fake2.
 Take the result of the 'fake2' install (see fake2/target/com.kaazing.gateway.fake2-1.1.1.1-SNAPSHOT-bin.tar.gz)
and unzip and untar it.  You will end up with a file (FAKE2_README.txt) and a directory (com.kaazing.gateway.fake1-1.1.1.1-SNAPSHOT-bin.tar.gz.)
 Notice that inside the directory is the file README.txt, and in that file you will see 

product: Foobar
version: 1.1

If you then go into fake2/src/main/assembly/unix-bin.xml (the assembly file) and change <filtered>true</filtered>
to <filtered>false</filtered> and rerun 'mvn install' for the project and untar
and unzip the tar.gz file, you'll see that there are only two files (FAKE2_README.txt and
README.txt), and no directory.  Notice that in this case, the file README.txt now says

product: ${product.name}
version: ${product.version}

That's the bug--if <filtered>true</filtered>, we get the extra diretory, which
contains the filtered version of the dependent file README.txt.  If <filtered>false</filtered>,
there is no extra directory, but no filtering, either.

> DependencySet unpackOptions 'filtered' causes unpack not to work
> ----------------------------------------------------------------
>
>                 Key: MASSEMBLY-554
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-554
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: Ubuntu 10.10 Linux, x86-64.  
>            Reporter: Dave Combs
>         Attachments: example.zip
>
>
> In 2.2-beta-4, the dependencySet option 'filtered' does not appear to work.  Files from
a dependency end up in the right place (under / in the fragment below), but the filters are
not applied.  In 2.2 it is worse--the files are correctly filtered, but a directory of the
same name as the archive from which they came (com.kaazing.gateway.assembly.core.tar.gz below)
is included in the output under /, rather than just the contents of the archive, and the filtered
files appear there.  It's as though the archive is exploded in place under its own name.
> <dependencySet>
>   <outputDirectory>/</outputDirectory>
>   <unpack>true</unpack>
>   <unpackOptions>
>     <filtered>true</filtered>
>   </unpackOptions>
>   <includes>
>     <include>com.kaazing.gateway.core:com.kaazing.gateway.assembly.core:tar.gz:bin</include>
>   </includes>
> </dependencySet>
> This makes the filtering option essentially unusable, since I can't find a way to eliminate
this top-level directory creation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message