maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukas Theussl (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (DOXIA-431) Doxia creates illegal URLs from local paths
Date Wed, 25 May 2011 06:33:22 GMT

    [ http://jira.codehaus.org/browse/DOXIA-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268412#action_268412
] 

Lukas Theussl commented on DOXIA-431:
-------------------------------------

I generally agree with your comments. The sanitize methods in URIPathDescriptor (I guess that's
what you are referring to) were necessary for some backward issues I encountered when re-writing
the deprecated PathDescriptor class. Note also the [comment in the relativizeLink|http://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/xref/org/apache/maven/doxia/site/decoration/inheritance/DefaultDecorationModelInheritanceAssembler.html#375]
method of DefaultDecorationModelInheritanceAssembler.

One thing I can point out is the javadoc in the Sink API for [figureGraphics|http://maven.apache.org/doxia/doxia/doxia-sink-api/apidocs/org/apache/maven/doxia/sink/Sink.html#figureGraphics(java.lang.String,
org.apache.maven.doxia.sink.SinkEventAttributes)], which states that the image src parameter
has to be a valid URL before being emitted into the Sink. So that's consistent with your remark
that data should be validated at the input side, ie by the Parser.

Otherwise, I think a concrete test example would help me to work on this, as I still don't
know where your figure is referenced from.

> Doxia creates illegal URLs from local paths
> -------------------------------------------
>
>                 Key: DOXIA-431
>                 URL: http://jira.codehaus.org/browse/DOXIA-431
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2
>            Reporter: Aaron Digulla
>
> If a local resource contains characters which are illegal in a URL, Doxia creates illegal
code or crashes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message