maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@codehaus.org>
Subject [jira] (MRELEASE-128) SCM properties being replaced during release:perform
Date Mon, 19 Mar 2012 22:48:04 GMT

     [ https://jira.codehaus.org/browse/MRELEASE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Scholte closed MRELEASE-128.
-----------------------------------

    Resolution: Fixed
      Assignee: Robert Scholte  (was: Brett Porter)

Fixed in [rev.1302692|http://svn.apache.org/viewvc?rev=1302692&view=rev]
For those interested: the main reason why the release-pom was okay and the next-dev-pom not
is because the release.pom was based on the originalModel of the MavenProject. The next-dev-pom
uses the releases.properties, which used to contain the resolved properties. After analyzing
this it seems that these property values are only used for rewriting the next-dev-pom.
So I've changed this, so the unresolved values are stored.
I've released a 2.3-SNAPSHOT for those who want to try this fix.
It would be nice if some could confirm this fix and that nothing is broken by this adjustment.

                
> SCM properties being replaced during release:perform
> ----------------------------------------------------
>
>                 Key: MRELEASE-128
>                 URL: https://jira.codehaus.org/browse/MRELEASE-128
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>         Environment: Windows XP client, Linux repo, CVS, Maven 2.0.4
>            Reporter: Craig Dickson
>            Assignee: Robert Scholte
>            Priority: Critical
>              Labels: properties
>             Fix For: 2.3
>
>         Attachments: after-release-perform-pom.xml, after-release-prepre-pom.xml, MNG-128-maven-release-manager.patch,
MRELEASE-128_cvs_hack_RewritePomsForDevelopmentPhase.java.patch, original-pom.xml
>
>
> The <scm> section of a pom in CVS for a pom archetype project looks like this prior
to executing release:prepare :
> <scm>
> 	<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
> 	<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
> 	<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
> </scm>
> Then after executing release:prepare, the pom in CVS looks like this (new <tag>
tag is only difference):
> <scm>
> 	<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
> 	<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
> 	<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
> 	<tag>R-1_7</tag>
> </scm>
> Then after executing release:perform, the pom looks like this in CVS:
> <scm>
> 	<connection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</connection>
> 	<developerConnection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</developerConnection>
> 	<url>http://behrcvs.masco-coatings.com/cgi-bin/viewcvs.cgi/commons-maven/uber-pom</url>
> </scm>
> Notice that the properties that were there for the base URLs for CVS and ViewCVS have
been replaced with literal values. 
> No other properties in the POM are being replaced

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message