maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Milos Kleint (JIRA)" <j...@codehaus.org>
Subject [jira] (MINDEXER-52) reentrant locking in DefaultIndexingContent flawed
Date Mon, 19 Mar 2012 09:33:03 GMT
Milos Kleint created MINDEXER-52:
------------------------------------

             Summary: reentrant locking in DefaultIndexingContent flawed
                 Key: MINDEXER-52
                 URL: https://jira.codehaus.org/browse/MINDEXER-52
             Project: Maven Indexer
          Issue Type: Bug
    Affects Versions: 4.1.2
            Reporter: Milos Kleint
            Priority: Critical


DefaultIndexingContent.java contains the following pattern:

{code:java}
    public IndexReader getIndexReader()
        throws IOException
    {
        lock();

        try
        {
            return indexReader;
        }
        finally
        {
            unlock();
        }
    }

{code}


together with installBottleWarmer() method that spawns a concurrent thread that performs "warmup"
operations, it makes it impossible to access the indexReader instance safely. A correct approach
would be to wrap the entire operation with the indexreader in the mutex lock, not the the
accessor method.

please see http://netbeans.org/bugzilla/show_bug.cgi?id=204706  and http://statistics.netbeans.org/exceptions/detail.do?id=180712
for examples when this approach is failing. it's fairly rare but  keeps on reoccuring, all
access (searching, indexing) from netbeans is protected by a mutex and happens exclusively.
I'm assuming that the installBottleWarmer() thread is the one iterfering with our access occasionally.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message