maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Eder (JIRA)" <j...@codehaus.org>
Subject [jira] (MNG-5208) Parallel (-T option) multi module build fires wrong "project failed event"
Date Mon, 03 Dec 2012 13:09:13 GMT

    [ https://jira.codehaus.org/browse/MNG-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314895#comment-314895
] 

Stefan Eder commented on MNG-5208:
----------------------------------

No problem. Used a "homemade" version of Maven 3.0.3 for Jenkins in the meantime. Nevertheless
looking forward to not having to patch the 3.1 version. ;)
                
> Parallel (-T option) multi module build fires wrong "project failed event"
> --------------------------------------------------------------------------
>
>                 Key: MNG-5208
>                 URL: https://jira.codehaus.org/browse/MNG-5208
>             Project: Maven 2 & 3
>          Issue Type: Bug
>    Affects Versions: 3.0.3
>         Environment: Maven 3.0.3 (+ Jenkins 1.430)
>            Reporter: Stefan Eder
>            Assignee: Kristian Rosenvold
>             Fix For: 3.1.0
>
>         Attachments: maven-core.patch
>
>
> It seems that a parallel multi module build reports the wrong failed module to an event
spy. Interestingly the reactor summary shows the right one but I imho the event for the listeners/spys
is fired in a wrong fashion.
> Let's assume the following scenario:
> * Master
> ** M1
> ** M2
> * M1 and M2 will be built parallel
> * M2 will fail because of a compilation error
> The events fired for this small scenario will look like this (simplified):
> # projectStarted(Master)
> # projectSucceeded(Master)
> # projectStarted(M1)
> # projectStarted(M2)
> # projectFailed(Master)
> In my opinion the last event should be fired with "M2", because this is the module that
actually fails. 
> The code where this happens can be found here:
> http://svn.apache.org/viewvc/maven/maven-3/tags/maven-3.0.3/maven-core/src/main/java/org/apache/maven/lifecycle/internal/BuilderCommon.java?view=markup
(@handleBuildError():137)
> http://svn.apache.org/viewvc/maven/maven-3/tags/maven-3.0.3/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java?view=markup
(@buildProject():95)
> So probably it is not right that the "rootSession" is used in the fire event statement
(at least that seems to confuse Jenkins), or am I mistaken?
> I almost forgot to mention: When a serial build is started then the last event would
be projectFailed(M2).
> For the curious this is the issue I opened (and closed) @Jenkins JIRA:
> https://issues.jenkins-ci.org/browse/JENKINS-11869

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message