maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darryl L. Miles (JIRA)" <j...@codehaus.org>
Subject [jira] (MRELEASE-808) prepare-with-pom needs to be run twice when <finalName> contains ${project.version}
Date Thu, 06 Dec 2012 10:42:13 GMT

    [ https://jira.codehaus.org/browse/MRELEASE-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=315108#comment-315108
] 

Darryl L. Miles commented on MRELEASE-808:
------------------------------------------

Test might succeed but does it relate to the problem ?

I have been using 2.3.2 also scm:git: also shouldn't the output version be 0.0.1, shouldn't
the output effective pom.xml not include any ${variables} ?  Indeed this is the nature of
the problem, the in memory model of the pom.xml is copied the project.version changed and
the variables not reinterpreted.

What is most important is if the plugin works for real (certainly for the source tree my commit
is based on '55dcd08' it did not work for real).  So before my patch is doesn't work after
my patch it does work, this has been tested by me.

I shall see if I can update and run your new test and then try each of these these things.
 But I suspect the new test does not touch the problem.  Maybe that is why it passes without
needing my patch.

                
> prepare-with-pom needs to be run twice when <finalName> contains ${project.version}
> -----------------------------------------------------------------------------------
>
>                 Key: MRELEASE-808
>                 URL: https://jira.codehaus.org/browse/MRELEASE-808
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3.2
>            Reporter: Darryl L. Miles
>         Attachments: 0001-MRELEASE-808-Allow-fixup-of-SNAPSHOT-version-in-fina.patch
>
>
> Setup your project with a <project><build><finalName> element setup
like:
> <finalName>${project.groupId}.${project.artifactId}-${project.version}</finalName>
> Setup ${project.version} to a SNAPSHOT like:
> <version>0.0.1-SNAPSHOT</version>
> The key thing here is the use of ${project.version} in the <finalName> and ew start
with a SNAPSHOT version trying to perform a release.
> Now we run: mvn release:prepare-with-pom
> It will bail out with error now and a message ... "Cannot reliably adjust the finalName
of project:" and I believe this is due to the -SNAPSHOT being visible and the code that throw
the exception is looking at the original, unedited version of the pom.xml.
> I think after editing the pom.xml the in-memory model should be refreshed and all ${variable}
be re-interpreted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message