maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lennart Jorelid (JIRA)" <j...@codehaus.org>
Subject [jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of "../"
Date Tue, 19 Feb 2013 07:39:14 GMT

    [ https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319956#comment-319956
] 

Lennart Jorelid commented on MSITE-669:
---------------------------------------

I agree, Herve; it seems that the patch could/should be applied to the stage-deploy goal as
well - with the added twitch that one must also define which URL should be used to find the
site ID, to enable the stage-deploy goal correctly interact with predefined userID and password
given in a server element within the effective settings.xml.

In stage-deploy, we have at least two URLs to play with:

# The [currently existing] stageSiteURL can be used to override the deployment upload URL.
# The [to be added] rootSiteURL can be used to define how we should relativize the intra-module
links within the staged site.

I believe that the most logical choice in finding settings.xml-defined UID/Password for upload
of data would be to use the data defined within settings.xml for the  stageSiteURL, rather
than the rootSiteURL. You agree here? This implies that the standard behaviour is used unless
overridden.
                
> site:stage creates incorrect structure when module paths contains sets of "../"
> -------------------------------------------------------------------------------
>
>                 Key: MSITE-669
>                 URL: https://jira.codehaus.org/browse/MSITE-669
>             Project: Maven 2.x and 3.x Site Plugin
>          Issue Type: Bug
>          Components: multi module, relative links, site:stage(-deploy)
>    Affects Versions: 3.1, 3.2
>            Reporter: Lennart Jorelid
>            Assignee: Lukas Theussl
>         Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png, sample.zip
>
>
> Given the module definitions given below, the site:stage goal produces sets of maps relative
to the staging directory - i.e. outside of the target directory.
> {code:xml} 
> <modules>
>   <module>../../validation/validation-api</module>
>   <module>../../validation/validation-aspect</module>
>   <module>../parent</module>
> </modules>
> {code}
> The staged site should be fully included within the staging directory. It would appear
that relativization of links for site:stage should take special links into consideration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message