From issues-return-85956-apmail-maven-issues-archive=maven.apache.org@maven.apache.org Tue Jul 2 20:41:30 2013 Return-Path: X-Original-To: apmail-maven-issues-archive@minotaur.apache.org Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 726C410A68 for ; Tue, 2 Jul 2013 20:41:30 +0000 (UTC) Received: (qmail 94655 invoked by uid 500); 2 Jul 2013 20:41:30 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 94619 invoked by uid 500); 2 Jul 2013 20:41:30 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 94611 invoked by uid 99); 2 Jul 2013 20:41:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2013 20:41:30 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [199.193.192.100] (HELO codehaus01.managed.contegix.com) (199.193.192.100) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2013 20:41:26 +0000 Received: from codehaus01 (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id A5DE4B0740 for ; Tue, 2 Jul 2013 15:41:05 -0500 (CDT) Date: Tue, 2 Jul 2013 15:41:05 -0500 (CDT) From: "Robert Scholte (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] (MWAR-150) Test for overlay.skip before resolving overlay dependency MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09 X-Virus-Checked: Checked by ClamAV on apache.org [ https://jira.codehaus.org/browse/MWAR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MWAR-150: -------------------------------- Description: I have a "master" pom that many projects share and inherit common build, report, dependency, etc. functionality from. I would like all of my .war projects to inherit from this "master" pom including my overlays and my projects that use the overlay. In my master pom I have: {code:xml} org.apache.maven.plugins maven-war-plugin 2.1-alpha-1 com.mycompany.app my-overlay {code} This obviously causes a problem when the overlay war is created because it cannot overlay itself with itself. So I get the error: {noformat} "overlay[ id com.mycompany.app:my-overlay] is not a dependency of the project." {noformat} I tried overriding the war plugin in the overlay pom and removed the overlays but there seemed to be some kind of inheritance thing going on where the overlays were still being added no matter what I did. (Might be a different issue?) Anyway, another way to fix this issue might be to use the "skip" attribute??? But I get the same error using {{true}}. Would it be possible to allow the "skip" attribute to be tested prior to overlay dependency checking? I've provided an example project of how I would like skip to function in a clean way that might help this problem of circular overlays. Mike was: I have a "master" pom that many projects share and inherit common build, report, dependency, etc. functionality from. I would like all of my .war projects to inherit from this "master" pom including my overlays and my projects that use the overlay. In my master pom I have: [code] org.apache.maven.plugins maven-war-plugin 2.1-alpha-1 com.mycompany.app my-overlay [/code] This obviously causes a problem when the overlay war is created because it cannot overlay itself with itself. So I get the error: "overlay[ id com.mycompany.app:my-overlay] is not a dependency of the project." I tried overriding the war plugin in the overlay pom and removed the overlays but there seemed to be some kind of inheritance thing going on where the overlays were still being added no matter what I did. (Might be a different issue?) Anyway, another way to fix this issue might be to use the "skip" attribute??? But I get the same error using true. Would it be possible to allow the "skip" attribute to be tested prior to overlay dependency checking? I've provided an example project of how I would like skip to function in a clean way that might help this problem of circular overlays. Mike > Test for overlay.skip before resolving overlay dependency > --------------------------------------------------------- > > Key: MWAR-150 > URL: https://jira.codehaus.org/browse/MWAR-150 > Project: Maven 2.x WAR Plugin > Issue Type: Improvement > Components: overlay > Affects Versions: 2.1-alpha-1 > Reporter: Mike Youngstrom > Attachments: skip-overlay.zip > > > I have a "master" pom that many projects share and inherit common build, report, dependency, etc. functionality from. I would like all of my .war projects to inherit from this "master" pom including my overlays and my projects that use the overlay. > In my master pom I have: > {code:xml} > > > > org.apache.maven.plugins > maven-war-plugin > 2.1-alpha-1 > > > > com.mycompany.app > my-overlay > > > > > > > > {code} > This obviously causes a problem when the overlay war is created because it cannot overlay itself with itself. So I get the error: > {noformat} > "overlay[ id com.mycompany.app:my-overlay] is not a dependency of the project." > {noformat} > I tried overriding the war plugin in the overlay pom and removed the overlays but there seemed to be some kind of inheritance thing going on where the overlays were still being added no matter what I did. (Might be a different issue?) > Anyway, another way to fix this issue might be to use the "skip" attribute??? But I get the same error using {{true}}. Would it be possible to allow the "skip" attribute to be tested prior to overlay dependency checking? I've provided an example project of how I would like skip to function in a clean way that might help this problem of circular overlays. > Mike -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira