maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benson Margulies (JIRA)" <j...@codehaus.org>
Subject [jira] (MCHECKSTYLE-166) Drop @requiresDependencyResolution test
Date Sun, 10 Nov 2013 22:12:20 GMT

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335532#comment-335532
] 

Benson Margulies commented on MCHECKSTYLE-166:
----------------------------------------------

Well, how about a patch with an integration test?
                
> Drop @requiresDependencyResolution test
> ---------------------------------------
>
>                 Key: MCHECKSTYLE-166
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-166
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>         Environment: N/A
>            Reporter: Ernst de Haan
>            Priority: Minor
>
> Currently, the [{{CheckstyleViolationCheckMojo}}|http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.8/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?revision=1188083&view=markup]
class declares:{code}@requiresDependencyResolution test{code}However, that should not be necessary.
Checkstyle works on source files, not on bytecode.
> If this declaration would be removed, then this Checkstyle plugin should still work perfectly
fine (I would expect without any further code changes).
> The advantage would be that in our Continuous Integration pipeline I can skip the _compile_
stage and immediately trigger the _checkstyle_ stage. That would save us multiple minutes
on the feedback roundtrip.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message