maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@codehaus.org>
Subject [jira] (MSHARED-198) custom delimiters doesn't work as expected
Date Sun, 09 Feb 2014 21:27:58 GMT

     [ https://jira.codehaus.org/browse/MSHARED-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Scholte closed MSHARED-198.
----------------------------------

       Resolution: Fixed
    Fix Version/s: maven-filtering-1.2
         Assignee: Robert Scholte

Fixed in [r1566429|http://svn.apache.org/r1566429]
I couldn't reproduce the triple 'a' testcase, the abc usecase exposed a serious bug.

> custom delimiters doesn't work as expected
> ------------------------------------------
>
>                 Key: MSHARED-198
>                 URL: https://jira.codehaus.org/browse/MSHARED-198
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-filtering
>    Affects Versions: maven-filtering-1.0
>            Reporter: Björn Michael
>            Assignee: Robert Scholte
>             Fix For: maven-filtering-1.2
>
>
> The algorithm doesn't work as described in http://maven.apache.org/plugins/maven-resources-plugin/apidocs/org/apache/maven/plugin/resources/ResourcesMojo.html#delimiters
> The implementation of org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read()
contains several bugs
> if the first letter of the endToken is contained in the propertyname then the property
is not filtered.
>   (e.g. abcFILTER.a.MEabc)
> if the first letter of the endToken is contained in the startToken then the property
is not filtered.
>   (e.g. aaaFILTER.a.MEaaa)
> <plugin>
>   <artifactId>maven-resources-plugin</artifactId>
>   <configuration>
>    <useDefaultDelimiters>false</useDefaultDelimiters>
>    <delimiters>
>      <delimiter>aaa*aaa</delimiter>
>      <delimiter>abc*abc</delimiter>
>    </delimiters>
>   </configuration>
> </plugin>



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message