maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Benson (JIRA)" <j...@codehaus.org>
Subject [jira] (MSHADE-167) [PATCH] When individual classes are renamed, they are not debuggable
Date Fri, 04 Apr 2014 17:52:59 GMT

     [ https://jira.codehaus.org/browse/MSHADE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matt Benson updated MSHADE-167:
-------------------------------

    Description: 
One can rename a given class using, e.g.:
{code}
<relocation>
  <pattern>com.example.foo.</pattern>
  <shadedPattern>com.uber._foo.__</shadedPattern>
</relocation>
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to {{com.uber.\_foo.\_\_Bar}}
and this is fine. If the source jar is generated, the {{.java}} file will be moved accordingly.
The proposed patch changes the source information in the relocated class to use the new basename
of the Java source file, making it possible to debug again. My Apache ICLA is on file, rights
are granted, and a test of the functionality is included.

  was:
you are correct, George, in thatOne can rename a given class using, e.g.:
{code}
<relocation>
  <pattern>com.example.foo.</pattern>
  <shadedPattern>com.uber._foo.__</shadedPattern>
</relocation>
{code}

Using the above relocation, {{com.example.foo.Bar}} will be relocated to {{com.uber.\_foo.\_\_Bar}}
and this is fine. If the source jar is generated, the {{.java}} file will be moved accordingly.
The proposed patch changes the source information in the relocated class to use the new basename
of the Java source file, making it possible to debug again. My Apache ICLA is on file, rights
are granted, and a test of the functionality is included. 


> [PATCH] When individual classes are renamed, they are not debuggable
> --------------------------------------------------------------------
>
>                 Key: MSHADE-167
>                 URL: https://jira.codehaus.org/browse/MSHADE-167
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Matt Benson
>         Attachments: shade-srcfile.patch.txt
>
>
> One can rename a given class using, e.g.:
> {code}
> <relocation>
>   <pattern>com.example.foo.</pattern>
>   <shadedPattern>com.uber._foo.__</shadedPattern>
> </relocation>
> {code}
> Using the above relocation, {{com.example.foo.Bar}} will be relocated to {{com.uber.\_foo.\_\_Bar}}
and this is fine. If the source jar is generated, the {{.java}} file will be moved accordingly.
The proposed patch changes the source information in the relocated class to use the new basename
of the Java source file, making it possible to debug again. My Apache ICLA is on file, rights
are granted, and a test of the functionality is included.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message