maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herve Boutemy (JIRA)" <j...@codehaus.org>
Subject [jira] (MNG-5626) Avoid negative durations or handle them correctly
Date Thu, 01 May 2014 14:36:10 GMT

    [ https://jira.codehaus.org/browse/MNG-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=345643#comment-345643
] 

Herve Boutemy commented on MNG-5626:
------------------------------------

+1
[from javadoc|http://docs.oracle.com/javase/7/docs/api/java/lang/System.html#nanoTime()],
nanoTime() seems to have been created (in Java 5, so no problem) exactly for this use case

I don't know if my OS supports CLOCK_MONOTONIC, but using nanoTime() should really improve
things: don't know if the warning will still happen, but it is a good defensive code

> Avoid negative durations or handle them correctly
> -------------------------------------------------
>
>                 Key: MNG-5626
>                 URL: https://jira.codehaus.org/browse/MNG-5626
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 3.2.1
>            Reporter: Christian Jung
>            Priority: Minor
>
> In issue MNG-5623 we reported an exception when printing the reactor summary if one of
the times was negative.
> I saw in one case, that the overall maven build time, as measured from outside (i.e.
by our QuickBuild system) was -10.8 seconds. The corresponding reactor summary was:
> {code}
> 13:55:25,184 INFO  - Reactor Summary:
> 13:55:25,184 INFO  -
> 13:55:25,184 INFO  - module1 ........................................... SUCCESS [ 5.911
s]
> 13:55:25,184 INFO  - module2 ........................................... SUCCESS [ 0.255
s]
> 13:55:25,184 INFO  - gpPlaygroundBase-lnx-x64-gcc4 ..................... SUCCESS [-27.-64
s]
> 13:55:25,185 INFO  - ------------------------------------------------------------------------
> 13:55:25,185 INFO  - BUILD SUCCESS
> 13:55:25,185 INFO  - ------------------------------------------------------------------------
> 13:55:25,185 INFO  - Total time: -20.-73 s
> 13:55:25,185 INFO  - Finished at: 2014-04-28T13:55:25+01:00
> 13:55:25,572 INFO  - Final Memory: 32M/439M
> 13:55:25,572 INFO  - ------------------------------------------------------------------------
> {code}
> The thing is quite hard to reproduce, the machines were virtual machines that have been
running for quite a long time.
> Our administrators suspected that just at this point, the local clock was synchronized
with some outer source.
> We should check if such negative durations can be avoided, and if not, they should be
handled correctly.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message