maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herve Boutemy (JIRA)" <j...@codehaus.org>
Subject [jira] (MPLUGIN-267) document how to change descriptor phase instead of running it twice with skipErrorNoDescriptorsFound
Date Thu, 05 Jun 2014 02:13:10 GMT

    [ https://jira.codehaus.org/browse/MPLUGIN-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=347524#comment-347524
] 

Herve Boutemy edited comment on MPLUGIN-267 at 6/4/14 9:12 PM:
---------------------------------------------------------------

because changing Maven core need to be carefully evaluated to avoid wreaking havoc for many
people
if we change newer Maven versions and people can't have a configuration working for many Maven
versions, that will be a problem
FYI, I discovered the Maven 2-specific configuration while deploting the idea: I didn't expect
the phase override not to work with Maven 2. So I continue to be careful

but now that this new configuration is found and MPLUGIN-238 is fixed too and when it will
be tested by multiple people whio don't report any unexpected issue, I think we should be
able to safely change Maven Core in a future version: what is a required configuration until
Maven 3.2 will probably become optional in Maven 3.3, because I think I can now safely propose
to implement MNG-5346 without requiring the latest Maven version

yes, with recent modifications, I think MNG-5346 can be implemented and in a "few" years,
when Maven 3.2 will be deprecated and not used any more by anybody, this documentation will
be removed :)


was (Author: hboutemy):
because changing Maven core need to be carefully evaluated to avoid wreaking havoc for many
people
if we change newer Maven versions and people can't have a configuration working for many Maven
versions, that will be a problem

now that this new configuration is found and MPLUGIN-238 is fixed too, I think we should be
able to safely change Maven Core in a future version: what is a required configuration until
Maven 3.2 will probably become optional in Maven 3.3, because I think I can now safely propose
to implement MNG-5346 without requiring the latest Maven version

yes, with recent modifications, I think MNG-5346 can be implemented and in a "few" years,
when Maven 3.2 will be deprecated and not used any more by anybody, this documentation will
be removed :)

> document how to change descriptor phase instead of running it twice with skipErrorNoDescriptorsFound
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-267
>                 URL: https://jira.codehaus.org/browse/MPLUGIN-267
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: Plugin Plugin
>    Affects Versions: 3.3
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>             Fix For: 3.4
>
>
> actual example says:
> {code:xml}  <build>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-plugin-plugin</artifactId>
>         <version>3.3</version>
>         <configuration>
>           <!-- see http://jira.codehaus.org/browse/MNG-5346 -->
>           <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
>         </configuration>
>         <executions>
>           <execution>
>             <id>mojo-descriptor</id>
>             <goals>
>               <goal>descriptor</goal>
>             </goals>
>           </execution>{code}
> this skipErrorNoDescriptorsFound configuration is not really good, since it does never
check if mojo descriptors can be found.
> A recent idea permits to avoid this: simply changing the phase of the actual goal, instead
of configuring a second run:
> {code:xml}  <build>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-plugin-plugin</artifactId>
>         <version>3.3</version>
>         <executions>
>           <execution>
>             <id>default-descriptor</id>
>             <phase>process-classes</phase>
>           </execution>{code}
> the key change is the default-descriptor execution id instead of mojo-descriptor.
> Notice: it works with Maven 3 but not with Maven 2...



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message