maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herve Boutemy (JIRA)" <j...@codehaus.org>
Subject [jira] (MTOOLCHAINS-3) PlexusConfiguration behavior in ToolchainConverter
Date Sun, 02 Nov 2014 13:05:10 GMT

    [ https://jira.codehaus.org/browse/MTOOLCHAINS-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=355428#comment-355428
] 

Herve Boutemy commented on MTOOLCHAINS-3:
-----------------------------------------

if we do such a change, the plugin won't work with Maven 2 any more

this patch can be applied when we upgrade to Maven 3 requirement

> PlexusConfiguration behavior in ToolchainConverter
> --------------------------------------------------
>
>                 Key: MTOOLCHAINS-3
>                 URL: https://jira.codehaus.org/browse/MTOOLCHAINS-3
>             Project: Maven Toolchains Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Tomas Radej
>         Attachments: plexus-to-sisu.patch
>
>
> Hi,
> when packaging the Toolchains plugin to Fedora, I saw that the ToolchainConverter class
of the Toolchains plugin depends on the old behavior of the PlexusConfiguration class, i.
e. the getValue() and getName() methods throwing a PlexusConfigurationException. However,
the new behavior of the PlexusConfiguration class (as found in Sonatype's Sisu, whose goal
is to replace Plexus) does not throw this exception, which causes the Toolchain plugin not
to compile when using the new library.
> The point of this bug is to consult with you moving from plexus-container-default to
sisu-inject-plexus, thus removing the try/catch block in src/main/java/org/apache/maven/plugin/toolchain/ToolchainConverter.java,
line 84. A patch to perform that action is attached.
> Thank you, Tomas Radej



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message