maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grégory Joseph (JIRA) <>
Subject [jira] (MSITE-738) SiteDeployMojo#determineDeploySite code/javadoc inconsistent. Javadoc seems more correct
Date Tue, 20 Jan 2015 15:33:17 GMT
Grégory Joseph created MSITE-738:

             Summary: SiteDeployMojo#determineDeploySite code/javadoc inconsistent. Javadoc
seems more correct
                 Key: MSITE-738
             Project: Maven Site Plugin
          Issue Type: Bug
          Components: site:deploy
    Affects Versions: 3.4
            Reporter: Grégory Joseph

The javadoc of this method seems to be the desired behavior:

     * Deploy directly to the current project's distribution management site.
    protected Site determineDeploySite()
        throws MojoExecutionException
        return getSite( getTopLevelProject( project ) );
However, the code indicates it goes all the way in the parent pom hierarchy ? Why ?
* The outcome is inconsistent with the effective-pom
* I'd assume if my pom declares a {{distributionManagement/site}} section, it should be used,
rather than the site plugin trying to be smarter and use the parent pom's info then somewhat
relativize ? This leads to the same issues I bumped into a couple years ago (when I didn't
bother plugging my debugger in) :

This can cause at least two problems:
* One can't deploy a site to a host that's different than that of the parent pom
* Permissions on the server-side might not be applied correctly (perhaps the project's deployer
doesn't have permissions to deploy into the path configured in the parent, but does in the
path of his project.. however we try to deploy to {{...parent/../../project/...}}.

Additionally, this just get confusing, because {{mvn help:effective-pom}} gives me the {{distributionManagement/site}}
section I expect, but the site plugin ends up doing something else. 

This message was sent by Atlassian JIRA

View raw message