maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schlichtherle (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MRESOURCES-190) Regression: The plugin is now silently ignoring .gitignore files.
Date Thu, 07 May 2015 17:15:00 GMT

    [ https://issues.apache.org/jira/browse/MRESOURCES-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533018#comment-14533018
] 

Christian Schlichtherle edited comment on MRESOURCES-190 at 5/7/15 5:14 PM:
----------------------------------------------------------------------------

The change in PLXUTILS-140 is simply a bad idea. If at all, the .git directory should be ignored,
not the .gitignore and .gitattributes files. Likewise for the .hg directory.

What's more important, this change also breaks the maven-source-plugin:2.4:jar-no-fork goal
for the same reason. It has a dependency on plexus-utils:3.0.18 .


was (Author: christians):
The change in PLXUTILS-140 is simply a bad idea. If at all, the .git directory should be ignored,
not the .gitignore and .gitattributes files. Likewise for the .hg directory.

What's more important, this change also breaks the maven-source-plugin:2.4:jar-bo-fork goal
for the same reason. It has a dependency on plexus-utils:3.0.18 .

> Regression: The plugin is now silently ignoring .gitignore files.
> -----------------------------------------------------------------
>
>                 Key: MRESOURCES-190
>                 URL: https://issues.apache.org/jira/browse/MRESOURCES-190
>             Project: Maven Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 2.7
>         Environment: Apache Maven 3.0.5
> Java version: 1.7.0_67, vendor: Oracle Corporation
> OS name: "linux" arch: "amd64", family: "unix"
>            Reporter: Josue Abarca
>             Fix For: 2.8
>
>
> Hi, I have a custom archetype that includes a ".gitignore" file in the generated projects.
> Since the change to Maven Resources Plugin 2.7, it seems that now it is silently excluding
the ".gitignore" files.
> If I change the pom to use the 2.6 version it works as expected.
> I looked in the changelog for 2.7 and I can not find any note about it, so it seems like
a regression.
> In the archetype-metadata.xml I have:
> <fileSet filtered="false" encoding="UTF-8">
>       <directory></directory>
>       <includes>
>         <include>.gitignore</include>
>       </includes>
> </fileSet>
> Here you can find an example project, that I am using for testing:
> https://github.com/jmaslibre/my-app-archetype
> Steps to reproduce:
> - Compile and install the archetype
> mvn clean install
> - Generate a project with the archetype
> cd ..
> mvn archetype:generate -DarchetypeGroupId=com.mycompany.app -DarchetypeArtifactId=my-app-archetype
-DarchetypeVersion=1.0-SNAPSHOT -DgroupId=customGroup -DartifactId=customproject -DinteractiveMode=false
> (unexpected) Current result :
> ls -a customproject/.gitignore
> ls: cannot access customproject/.gitignore: No such file or directory
> Expected result:
> ls -a customproject/.gitignore
> customproject/.gitignore
> Using:
> Apache Maven 3.0.5
> Java version: 1.7.0_67, vendor: Oracle Corporation
> OS name: "linux" arch: "amd64", family: "unix"
> If you need more information just let me know.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message