maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1153) Take includes into account when using test/it.test property
Date Tue, 19 May 2015 23:26:00 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551448#comment-14551448
] 

ASF GitHub Bot commented on SUREFIRE-1153:
------------------------------------------

GitHub user Tibor17 opened a pull request:

    https://github.com/apache/maven-surefire/pull/94

    [SUREFIRE-1153] Take includes into account when using test/it.test property

    As discussed we Andreas we agreed on SUREFIRE-1153 acceptance where the includes/excludes
list is ignored as soon as test or it.test (sys.property) is specified whatever execution
phase runs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Tibor17/maven-surefire s4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit c67bff883556522f855c572a8486c290dfc62c7a
Author: Tomas Rohovsky <trohovsk@redhat.com>
Date:   2015-04-10T19:49:01Z

    SUREFIRE-1153 Take includes into account when using test/it.test property

commit 49676d19a7ae909dc737a5a534b8cd79b76e6f42
Author: Tomas Rohovsky <trohovsk@redhat.com>
Date:   2015-05-16T13:29:04Z

    SUREFIRE-1153 Integration test

commit 517df5ffcc9041462b3603310dfe0843afb59dfc
Author: Tibor17 <tibor17@lycos.com>
Date:   2015-05-19T22:41:36Z

    [SUREFIRE-1153] Take includes into account when using test/it.test property

----


> Take includes into account when using test/it.test property
> -----------------------------------------------------------
>
>                 Key: SUREFIRE-1153
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
>             Project: Maven Surefire
>          Issue Type: Improvement
>    Affects Versions: 2.18.1
>            Reporter: Tomas Rohovsky
>             Fix For: 2.19
>
>         Attachments: failsafe-test-parameter.zip
>
>
> Currently test/it.test property overrides includes and excludes parameters. I think that
it would be better to take includes into account. Lets have this configuration as an example:
> {code}
> <plugin>
> 	<groupId>org.apache.maven.plugins</groupId>
> 	<artifactId>maven-failsafe-plugin</artifactId>
> 	<version>2.18.1</version>
> 	<configuration>
> 		<includes>
> 			<include>**/*Test.java</include>
> 		</includes>
> 	</configuration>
> 	<executions>
> 		<execution>
> 			<goals>
> 				<goal>integration-test</goal>
> 				<goal>verify</goal>
> 			</goals>
> 		</execution>
> 	</executions>
> </plugin>
> {code}
> If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will end up with:
> {code}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test
(default) on project failsafe-test-parameter: No tests were executed!  (Set -DfailIfNoTests=false
to ignore this error.) -> [Help 1]
> {code}
> Sure, you can specify the class name: {{mvn verify -Dit.test=ExampleTest#testFailsafe}}
and it will work. But it is more convenient to not do that.
> A reproducer is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message