maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Graham (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
Date Sun, 16 Aug 2015 08:34:46 GMT

    [ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698586#comment-14698586
] 

Chris Graham commented on MPIR-234:
-----------------------------------

>Say you are looking at a projects site.

>You say, "oh where's the source code".

>You go to the "source repository" report for that module.

Which points to the base SCM url.

I find this very much of an edge case. I've never needed, as I've never - ever - only wanted
to check out *just* a module, only the entire thing. Personally, I do not understand such
a use case. Well, I can think of one, but I'm not going to write it here.

What I'd propose is this (short of a full and complete redesign of the SCM API to make it
MORE abstract, and move it away from it's CVS/SVN roots):

Each SCM Provider interface adds another method:

boolean isCapableOfModuleCheckout();

Git, RTC, Git, Clearcase etc would return false. AFAIK, only CVS and SVN would return true.

If you get a method not found error, then you'd have to return true, so as to assume consistent
(old style) behaviour. This would only apply to old versions of non apache providers that
do not support the interface (are there any that anyone knows of?).


> SCM-link in site of multimodule projects should not append module name by default (at
least for git)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MPIR-234
>                 URL: https://issues.apache.org/jira/browse/MPIR-234
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Bug
>          Components: scm
>    Affects Versions: 2.4
>            Reporter: Mirko Friedenhagen
>
> I have setup a simple multi module project (see https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by default add the
name of the module to the SCM-URLs in source-repository.html. So instead of https://github.com/mfriedenhagen/multi-module-sample/
I see https://github.com/mfriedenhagen/multi-module-sample/core/, git@github.com:mfriedenhagen/multi-module-sample.git/core
and git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for the core
module. All these URLs are invalid. For SVN this could be assumed to be the right behaviour,
for git and probably other SCMs this is not true. As a workaround I have to reconfigure the
scm section (see https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
> {code:xml}
> <scm>
>   <connection>${project.parent.scm.connection}</connection>
>   <developerConnection>${project.parent.scm.developerConnection}</developerConnection>
>   <url>${project.parent.scm.url}</url>
> </scm>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message