maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Beirtí Ó'Nunáin (JIRA) <j...@apache.org>
Subject [jira] [Created] (MDEP-501) Filtering dependencies does not retain the order of the unfiltered list
Date Mon, 07 Sep 2015 12:25:45 GMT
Beirtí Ó'Nunáin created MDEP-501:
------------------------------------

             Summary: Filtering dependencies does not retain the order of the unfiltered list
                 Key: MDEP-501
                 URL: https://issues.apache.org/jira/browse/MDEP-501
             Project: Maven Dependency Plugin
          Issue Type: Bug
    Affects Versions: 2.10
            Reporter: Beirtí Ó'Nunáin


If you use the build-classpath mojo, you get the dependency list as specified in the pom.
However, if you introduce filtering, you end up losing the dependency order. It seems that
the org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter declares 'Set' instead
of 'SortedSet' and that the org.apache.maven.shared.artifact.filter.collection.AbstractArtifactFeatureFilter
returns a HashSet instead of a LinkedHashSet, even though a LinkedHashSet is being passed
in.

The impact of this is that you cannot generate a correctly-ordered classpath when using filters.
The fix is very straightforward, simply change the filterIncludes and filterExcludes methods
of AbstractArtifactFeatureFilter to use a LinkedHashSet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message