maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trask Stalnaker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHADE-206) Multi-module builds don't pick up dependency-reduced-pom.xml
Date Fri, 02 Oct 2015 00:20:26 GMT

    [ https://issues.apache.org/jira/browse/MSHADE-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940628#comment-14940628
] 

Trask Stalnaker commented on MSHADE-206:
----------------------------------------

I did some bisecting and found the maven commit that broke this for me:

https://github.com/apache/maven/commit/be3fb200326208ca4b8c41ebf16d5ae6b8049792

In particular, that commit introduced some code to not rebuild the model if it was already
loaded during reactor resolution.

I think that is causing maven not to use the updated "dependency reduced" pom that has been
created by the maven-shade-plugin.

Removing this code fixes the situation for me.  I'm hoping that code was just introduced as
a performance optimization, and that I haven't broken anything functionally by removing it
(the tests still pass at least).

I forked the maven project and pushed the fix here if you want to try it: https://github.com/trask/maven/tree/MSHADE-206

I think we will need to submit this issue to the maven project, but I will wait a bit for
your analysis to see if you are facing the same issue.

Thanks,
Trask


> Multi-module builds don't pick up dependency-reduced-pom.xml
> ------------------------------------------------------------
>
>                 Key: MSHADE-206
>                 URL: https://issues.apache.org/jira/browse/MSHADE-206
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>            Reporter: Robert Joseph Evans
>
> I'm not sure if there is a good solution for this or not.  As part of the Apache Storm
project we are trying to shade a lot of dependencies for the core platform (storm-core), but
we also have other modules in the same build that depend on storm-core, but use the shade
plugin to create an uber jar for deployment.  The problem is that if we build all of the modules
at once and let maven handle resolving dependencies the uber jar projects don't see storm-core's
dependency-reduced-pom.xml.  They see the original pom.xml and end up not packaging dependencies
that they need.
> Our "fix" for this https://github.com/apache/storm/pull/736 is to split the build up
into two phases.  One that just builds storm-core and another that builds the rest.  This
is going to be a real pain for developers.  Are we doing something wrong?  Is this working
as expected? 
> I am happy to submit a fix for this, but I am far from an expert on maven so if someone
in this project sees a direction that I can go in to fix this I would appreciate any guidance
you might have.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message