maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trask Stalnaker (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MNG-5899) Reactor is no longer using the dependency reduced pom created by maven-shade-plugin
Date Sat, 03 Oct 2015 00:05:26 GMT
Trask Stalnaker created MNG-5899:
------------------------------------

             Summary: Reactor is no longer using the dependency reduced pom created by maven-shade-plugin
                 Key: MNG-5899
                 URL: https://issues.apache.org/jira/browse/MNG-5899
             Project: Maven
          Issue Type: Bug
    Affects Versions: 3.3.3, 3.3.1
            Reporter: Trask Stalnaker


This works with maven 3.2.5 and prior, but does not work with the latest releases (3.3.1 and
3.3.3), or master (tested against 3.3.7-SNAPSHOT).

I did some bisecting and found the commit that caused the breakage:

https://github.com/apache/maven/commit/be3fb200326208ca4b8c41ebf16d5ae6b8049792

In particular, this commit introduced some code to not rebuild the model if it was already
loaded during reactor resolution.

This is causing maven not to use the dependency reduced pom created by the maven-shade-plugin.

Removing this code fixes the situation.  I'm hoping that code was just introduced as a performance
optimization, and that I haven't broken anything functionally by removing it (the tests still
pass at least).

I will submit a pull request with the change for review.

Here is the original maven-shade-plugin issue as reported by the Apache Storm team: https://issues.apache.org/jira/browse/MSHADE-206




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message