[ https://issues.apache.org/jira/browse/MNG-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941979#comment-14941979
]
ASF GitHub Bot commented on MNG-5899:
-------------------------------------
GitHub user trask opened a pull request:
https://github.com/apache/maven/pull/69
MNG-5899 Reactor should use reduced dependency pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trask/maven MNG-5899
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 1ca0deec41814815d82033645ca00fe6bbfdd813
Author: Trask Stalnaker <trask.stalnaker@gmail.com>
Date: 2015-10-01T22:09:41Z
MNG-5899 Reactor should use reduced dependency pom
----
> Reactor is no longer using the dependency reduced pom created by maven-shade-plugin
> -----------------------------------------------------------------------------------
>
> Key: MNG-5899
> URL: https://issues.apache.org/jira/browse/MNG-5899
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.3.1, 3.3.3
> Reporter: Trask Stalnaker
>
> This works with maven 3.2.5 and prior, but does not work with the latest releases (3.3.1
and 3.3.3), or master (tested against 3.3.7-SNAPSHOT).
> I did some bisecting and found the commit that caused the breakage:
> https://github.com/apache/maven/commit/be3fb200326208ca4b8c41ebf16d5ae6b8049792
> In particular, this commit introduced some code to not rebuild the model if it was already
loaded during reactor resolution.
> This is causing maven not to use the dependency reduced pom created by the maven-shade-plugin.
> Removing this code fixes the situation. I'm hoping that code was just introduced as
a performance optimization, and that I haven't broken anything functionally by removing it
(the tests still pass at least).
> I will submit a pull request with the change for review.
> Here is the original maven-shade-plugin issue as reported by the Apache Storm team: https://issues.apache.org/jira/browse/MSHADE-206
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|