maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (SUREFIRE-1202) Allow rerunFailingTestsCount, skipAfterFailureCount together
Date Fri, 04 Dec 2015 08:43:11 GMT


ASF GitHub Bot commented on SUREFIRE-1202:

Github user seanf commented on the pull request:
    Hi Tibor,
    I don't understand. Are you saying you did try to build an IT for this?
    Could you share it, please? What counts would you consider realistic?
    I won't have any time to look at the code for a few days, but running a
    test more than once *in series* (not parallel) should not affect
    concurrency, because the test hasn't failed until all runs for that test
    have finished.
    I'm still assuming failureCount is meant to count failed tests, not bad
    runs. You didn't answer my question about that (and the docs don't say),
    but I do think it is better to count tests, as long as it is documented.
    As I said, there should be no race condition if failureCount counts
    (completely) failed tests, assuming the runs for each test are serialised.
    On 3 December 2015 at 01:38, Tibor Digana <> wrote:
    > Try to build IT with your code with more realistic counts, but the
    > fail-fast feature would not be coherent due to concurrency problem across
    > forks.
    > —
    > Reply to this email directly or view it on GitHub
    > <>
    > .

> Allow rerunFailingTestsCount, skipAfterFailureCount together
> ------------------------------------------------------------
>                 Key: SUREFIRE-1202
>                 URL:
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin
>    Affects Versions: 2.19
>            Reporter: Sean Flanigan
>            Assignee: Tibor Digana
> I couldn't find this limitation documented anywhere, but if I try to use the options
{{rerunFailingTestsCount}} and {{skipAfterFailureCount}} together, I get this error message:
> {noformat}
> org.apache.maven.plugin.MojoFailureException: 
> Parameters ["rerunFailingTestsCount", "skipAfterFailureCount"] 
> should not be enabled together
> {noformat}
> I have a use case which requires both options: some integration tests are flaky, so I
want to use {{rerunFailingTestsCount}} to repeat them, but if all tests are failing (eg due
to a configuration problem or a really bad change), I don't want to wait for the entire test
suite to fail multiple times, so I would like to abort if say 10 tests have failed.

This message was sent by Atlassian JIRA

View raw message