maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (MSHARED-385) Specify lineEnding style in Plexus Archiver
Date Fri, 01 Jan 2016 02:05:39 GMT

     [ https://issues.apache.org/jira/browse/MSHARED-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Osipov closed MSHARED-385.
----------------------------------
    Resolution: Won't Fix

Closing this as won't fix for several reasons:

1. {{lineEnding}} applies to files processed by the Assembly Plugin and then passed to Maven
Archiver but the {{MANIFEST.MF}} is not passed as a file but as configuration. Cannot work
here.
2. Plexus Archiver has some issues of its own, I have reported [them|https://github.com/codehaus-plexus/plexus-archiver/issues/created_by/michael-o].
3. I can only confirm what Kristian says, while it is true that Plexus Archiver has its own
{{Manifest}} class it still extends {{java.util.jar.Manifest}}. The {{writeManifest}} method
delegates to {{java.util.jar.Manifest#write(OutputStream}} method. This method is built in
the Java runtime system, if you look at the [implementation|http://www.grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u40-b25/java/util/jar/Manifest.java#Manifest.write%28java.io.OutputStream%29]
of the {{write}} method, you'll see that the line ending is *hardcoded* and does not correspond
to {{line.ending}}.

Ultimately, this is a bug in the Java library we cannot fix. You have to file this with Oracle.

> Specify lineEnding style in Plexus Archiver
> -------------------------------------------
>
>                 Key: MSHARED-385
>                 URL: https://issues.apache.org/jira/browse/MSHARED-385
>             Project: Maven Shared Components
>          Issue Type: New Feature
>          Components: maven-archiver
>            Reporter: Rubén Suárez Alvarez
>            Priority: Minor
>
> From: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452123
> MANIFEST.MF generation is delegated to 
> https://maven.apache.org/shared/maven-archiver/ which eventually relies on
> https://github.com/sonatype/plexus-archiver/blob/master/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java#L89
> There's no way to set custom EOL anywhere in the process.
> In Maven Assembly Plugin (http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html)
you can use "lineEnding" element but you can't set it in anyway in plexus archiver.
> If It can't be specified via configuration, at least default system line end style (System.getProperty("line.separator"))
should be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message