maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Lange (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (WAGON-448) Use Java String replace to avoid commons-lang dependency
Date Sat, 02 Jan 2016 15:24:39 GMT

     [ https://issues.apache.org/jira/browse/WAGON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Fabian Lange updated WAGON-448:
-------------------------------
    Description: 
I am trying to reduce the amount of dependencies of the Apache Karaf project.
One of the subcomponents uses wagon-http and wagon-file. By doing so, it receives a dependency
to commons-lang.

The reason is that wagon-file has a single use of StringUtils.replaceAll().

https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206

This dependency can be easily avoided using the JDK util 
{code}
destinationPath.replace('\\', '/');
{code}
while this is also a bit faster, the main benefit is that we now can completely remove the
lang dependency.

Thank you!

  was:
I am trying to reduce the amount of dependencies of the Apache Karaf project.
One of the subcomponents uses wagon-http and wagon-file. By doing so, it receives a dependency
to commons-lang.

The reason is that wagon-file has a single use of StringUtils.replaceAll().

https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206

This dependency can be easily avoided using the JDK util destinationPath.replace('\\', '/');
while this is also a bit faster, the main benefit is that we now can completely remove the
lang dependency.

Thank you!


> Use Java String replace to avoid commons-lang dependency
> --------------------------------------------------------
>
>                 Key: WAGON-448
>                 URL: https://issues.apache.org/jira/browse/WAGON-448
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>            Reporter: Fabian Lange
>
> I am trying to reduce the amount of dependencies of the Apache Karaf project.
> One of the subcomponents uses wagon-http and wagon-file. By doing so, it receives a dependency
to commons-lang.
> The reason is that wagon-file has a single use of StringUtils.replaceAll().
> https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206
> This dependency can be easily avoided using the JDK util 
> {code}
> destinationPath.replace('\\', '/');
> {code}
> while this is also a bit faster, the main benefit is that we now can completely remove
the lang dependency.
> Thank you!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message