maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPMD-219) Maven PMD Plugin ignores PMD processing errors
Date Mon, 25 Jan 2016 11:51:40 GMT

    [ https://issues.apache.org/jira/browse/MPMD-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115088#comment-15115088
] 

ASF GitHub Bot commented on MPMD-219:
-------------------------------------

GitHub user adangel opened a pull request:

    https://github.com/apache/maven-plugins/pull/80

    [MPMD-219] PMD processing errors should fail build (skipPmdError=false)

    This commit adds a "PmdCollectingRenderer" and uses it instead of
    the report listener, as listeners are unfortunately not informed about
    errors.
    If the "skipPmdError" property is true (default),
    then these processing errors are logged as warnings.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adangel/maven-plugins MPMD-219

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #80
    
----
commit d9c298f27c54c7f215fe58a78d87e1519d4dff1c
Author: Andreas Dangel <adangel@users.sourceforge.net>
Date:   2016-01-25T11:49:33Z

    [MPMD-219] PMD processing errors should fail build (skipPmdError=false)
    This commit adds a "PmdCollectingRenderer" and uses it instead of
    the report listener, as listeners are unfortunately not informed about
    errors.
    If the "skipPmdError" property is true (default),
    then these processing errors are logged as warnings.

----


> Maven PMD Plugin ignores PMD processing errors
> ----------------------------------------------
>
>                 Key: MPMD-219
>                 URL: https://issues.apache.org/jira/browse/MPMD-219
>             Project: Maven PMD Plugin
>          Issue Type: Bug
>          Components: PMD
>    Affects Versions: 3.6
>            Reporter: Andreas Dangel
>            Priority: Minor
>
> If a source file cannot be parsed by PMD, the error is reported as a "processing error"
and continues with the next file.
> However, the maven plugin doesn't use this information. This leads to a situation, where
project build is successful despite PMD violations - because PMD skipped files which it can't
parse.
> This is not such a big problem if the files are compiled before (e.g. executing PMD in
a phase later than compile) - as the compiler plugin would fail the build already.
> But if "pmd:pmd" or "pmd:check" is called directly, maven would not fail the build.
> See also https://sourceforge.net/p/pmd/mailman/message/34715839/
> I'll provide a PR for this bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message