maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tibor Digana (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SUREFIRE-1227) The Description argument RunListener#testRunStarted(Description) doesn't include test methods
Date Wed, 10 Feb 2016 02:42:18 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140228#comment-15140228
] 

Tibor Digana edited comment on SUREFIRE-1227 at 2/10/16 2:41 AM:
-----------------------------------------------------------------

[~jlocker@redhat.com]
Is this fix very important for you?
We had to do this because otherwise you would reach NPE since of null in the method argument.
Other users argued that Arquillian runner was started twice, it's because of discoverying
the children. That's the reason we did not use JUnit to ask for children. On the other side
we did pass only description without having the children. In order to substitute JUnit it
would never be successful without using real runner. Some runners are not so transparent (Parameterized,
Cucumber) like pure non-parameterized JUnit runner and better to prevent from null description
however with missing children.


was (Author: tibor17):
[~jlocker@redhat.com]
Is this fix very important for you?
We had to do this because otherwise you would reach NPE since of null in the method argument.
Other users argued that Arquillian runner was started twice, it's because of discoverying
the children. That's the reason we did not use JUnit to ask for children. On the other side
we did pass only description without having the children. In order to substitute JUnit it
would never be successful without using real runner. Some runners are not so transparent (Parameterized,
Cucumber) like JUnit runners and better to prevent from null description however missing children.

> The Description argument RunListener#testRunStarted(Description) doesn't include test
methods
> ---------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1227
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1227
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.19.1
>            Reporter: Jiri Locker
>         Attachments: maven-surefire-run-listener.zip
>
>
> In Surefire 2.19 the Description passed to testRunStarted() is a test run description
and has 2 levels of children (test classes > test methods). The top level Description's
testCount property is equal to the number of test methods in all test classes that are going
to be run. When dumping the description tree it may look like this:
> {noformat}
> Description: ~ null (6)
> Description: ~ ~ io.github.yurloc.example.runlistener.MyFirstTest (2)
> Description: ~ ~ ~ testMethod1(io.github.yurloc.example.runlistener.MyFirstTest) (1)
> Description: ~ ~ ~ testMethod2(io.github.yurloc.example.runlistener.MyFirstTest) (1)
> Description: ~ ~ io.github.yurloc.example.runlistener.MySecondTest (4)
> Description: ~ ~ ~ testMethodA(io.github.yurloc.example.runlistener.MySecondTest) (1)
> Description: ~ ~ ~ testMethodB(io.github.yurloc.example.runlistener.MySecondTest) (1)
> Description: ~ ~ ~ testMethodC(io.github.yurloc.example.runlistener.MySecondTest) (1)
> Description: ~ ~ ~ testMethodD(io.github.yurloc.example.runlistener.MySecondTest) (1)
> {noformat}
> However in Surefire 2.19.1 the leaf descriptions of test methods are missing:
> {noformat}
> Description: ~ null (2)
> Description: ~ ~ io.github.yurloc.example.runlistener.MyFirstTest (1)
> Description: ~ ~ io.github.yurloc.example.runlistener.MySecondTest (1)
> {noformat}
> Because of this I am unable to access the total test count, which I use to calculate
ETA of the test run finish. I seem that this change of behavior was introduced by fixing SUREFIRE-1187.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message