maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (DOXIASITETOOLS-87) inconsistent newlines between template content from skin and generated content
Date Wed, 02 Mar 2016 17:00:20 GMT

    [ https://issues.apache.org/jira/browse/DOXIASITETOOLS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175978#comment-15175978
] 

Hervé Boutemy edited comment on DOXIASITETOOLS-87 at 3/2/16 4:59 PM:
---------------------------------------------------------------------

q. I think this should be reverted for now
-1 if you want to improve, don't hesitate to open a new Jira issue and do the improvement

q. this should not be done at Velocity level because it is not a Velocity problem
who says it is a Velocity problem? It is a SiteRenderer issue when using Velocity to evaluate
template

q. We could simply write a NormalizingWriter, this should do
if you can inject this writer into Velocity, that will do the job (as doing it at reading
level is exactly the same)
but for sure, if it could be done through readers/writers instead of streams, it would be
easier to deal with encoding


was (Author: hboutemy):
q. I think this should be reverted for now
-1 if you want to improve, don't hesitate to open a new Jira issue and do the improvement

q. this should not be done at Velocity level because it is not a Velocity problem
who says it is a Velocity problem? It is a SiteRenderer issue when using Velocity to evaluate
template

q. We could simply write a NormalizingWriter, this should do
if you can inject this writer into Velocity, that will do the job (as doing it at reading
level is exactly the same)

> inconsistent newlines between template content from skin and generated content
> ------------------------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-87
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-87
>             Project: Maven Doxia Sitetools
>          Issue Type: Bug
>          Components: Site renderer
>            Reporter: Hervé Boutemy
>            Assignee: Hervé Boutemy
>             Fix For: 1.6
>
>
> template from skin artifact is read with newline set from skin artifact builder
> then content is added into it with current newline, which can be different from artifact
builder
> Template newline should be harmonized with current newline
> this causes MSITE-121 and requires hack in [maven-scm-publish-plugin|http://maven.apache.org/plugins/maven-scm-publish-plugin/]
([copyAndNormalizeNewlines( File srcFile, File destFile )|http://maven.apache.org/plugins-archives/maven-scm-publish-plugin-1.0-beta-2/xref/org/apache/maven/plugins/scmpublish/ScmPublishPublishScmMojo.html#180])



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message