maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARCHETYPE-491) Allow to run integration test with another archetype as parent project
Date Sun, 10 Jul 2016 18:15:11 GMT

    [ https://issues.apache.org/jira/browse/ARCHETYPE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369874#comment-15369874
] 

ASF GitHub Bot commented on ARCHETYPE-491:
------------------------------------------

Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven-archetype/pull/8#discussion_r70186173
  
    --- Diff: maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/src/test/resources/projects/basic/reference/pom.xml
---
    @@ -0,0 +1,32 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +--><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +  <parent>
    +    <artifactId>project</artifactId>
    +    <groupId>com.company</groupId>
    +    <version>1.0-SNAPSHOT</version>
    +  </parent>
    +
    +  <groupId>archetype.it</groupId>
    +  <artifactId>basic</artifactId>
    +  <version>0.1-SNAPSHOT</version>
    --- End diff --
    
    This `<vesion>` is redundant unless you want to override parent. Remove.


> Allow to run integration test with another archetype as parent project
> ----------------------------------------------------------------------
>
>                 Key: ARCHETYPE-491
>                 URL: https://issues.apache.org/jira/browse/ARCHETYPE-491
>             Project: Maven Archetype
>          Issue Type: Improvement
>          Components: Plugin
>    Affects Versions: 2.4
>            Reporter: Konrad Windszus
>            Assignee: Michael Osipov
>             Fix For: 2.5
>
>
> Archetypes can be either used as module archetypes (below existing Maven projects, then
the parent will be automatically set) or as regular project archetypes (i.e. will run standalone,
because they need no parent or have a parent hardcoded in their pom). Currently only the latter
is properly supported for the goal {{integration-test}}.
> To also support the former it would be good to allow the setup of arbitrary parent structures
(from other archetypes) below which the actual IT should be executed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message