maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHARED-598) Simplify ProjectInstaller by not requiring an ArtifactRepository
Date Sun, 30 Oct 2016 20:04:58 GMT

    [ https://issues.apache.org/jira/browse/MSHARED-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15620494#comment-15620494
] 

Hudson commented on MSHARED-598:
--------------------------------

SUCCESS: Integrated in Jenkins build maven-shared #3001 (See [https://builds.apache.org/job/maven-shared/3001/])
[MSHARED-598] Simplify ProjectInstaller by not requiring an ArtifactRepository

Part 2 - Removing the "install" overload taking the ArtifactRepository (gboue: [http://svn.apache.org/viewvc/?view=rev&rev=1767178])
* (edit) maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/ProjectInstaller.java
* (edit) maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java


> Simplify ProjectInstaller by not requiring an ArtifactRepository
> ----------------------------------------------------------------
>
>                 Key: MSHARED-598
>                 URL: https://issues.apache.org/jira/browse/MSHARED-598
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-artifact-transfer
>            Reporter: Guillaume Boué
>            Assignee: Guillaume Boué
>             Fix For: maven-artifact-transfer-0.9.0
>
>
> With the changes made in [MSHARED-596|https://issues.apache.org/jira/browse/MSHARED-596],
{{ProjectInstaller}} does not need an {{ArtifactRepository}} anymore:
> - To set a different local repository, it is possible to use the {{RepositoryManager}}
and call the {{setLocalRepositoryBasedir}} method on the building request which is passed
as parameter.
> - It was only used to fetch local metadata file, but this is now possible directly with
{{RepositoryManager}}.
> As such, the method
> {code:java}
> void install( ProjectBuildingRequest projectBuildingRequest, ProjectInstallerRequest
projectInstallerRequest, ArtifactRepository artifactRepository )
> {code}
> should be removed in favor of
> {code:java}
> void install( ProjectBuildingRequest projectBuildingRequest, ProjectInstallerRequest
projectInstallerRequest )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message