maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Boué (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MPH-105) Effective pom aggregation is not triggered
Date Sat, 12 Nov 2016 23:17:58 GMT

    [ https://issues.apache.org/jira/browse/MPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660456#comment-15660456
] 

Guillaume Boué commented on MPH-105:
------------------------------------

This check was added to take into account direct binding of the {{effective-pom}} goal, in
the POM, during a phase of the lifecycle. In that case, it lists all effective POMs in the
reactor only for the head project; for the other projects in the reactor, it will only list
their effective-pom during the build.

Now that the plugin has been migrated to Maven 3, there is a good way to determine if the
plugin was invoked from the command-line or not by looking at the source of the mojo execution.
This behaviour needs to be kept only when the plugin is invoked from within a POM; on the
command-line, all the effective POMs should be written.

Fixed in [r1769446|http://svn.apache.org/viewvc?rev=1769446&view=rev].

> Effective pom aggregation is not triggered
> ------------------------------------------
>
>                 Key: MPH-105
>                 URL: https://issues.apache.org/jira/browse/MPH-105
>             Project: Maven Help Plugin
>          Issue Type: Bug
>          Components: effective-pom
>    Affects Versions: 2.2
>         Environment: Maven 3.0.5
>            Reporter: Wisen Tanasa
>             Fix For: waiting-for-feedback
>
>         Attachments: MPH-105.patch
>
>
> Patch attached and contains JUnit.
> The bug is happening when it hits this portion and `projects.get( 0 ).equals( project
)` is returning false. In my JUnit, this is happening when a sub module's parent is not the
aggregator pom.
> EffectivePomMojo.java#90:
> {code}
> if ( projects.get( 0 ).equals( project ) && projects.size() > 1 )
> {code}
> Is the first check really necessary?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message