maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schulte (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MASSEMBLY-756) escapeString doesn't work correctly for the 2nd filtering
Date Wed, 07 Dec 2016 15:55:58 GMT

    [ https://issues.apache.org/jira/browse/MASSEMBLY-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729086#comment-15729086
] 

Christian Schulte commented on MASSEMBLY-756:
---------------------------------------------

May I ask what the escape string is set to? Is it set to a single backslash? I am asking because
this {code}\\${id}{code} would need to become {code}\\value of id{code} after filtering! That's
what the {{maven-resources-plugin}} would produce intentionally. Having said that, the description
of the issue is wrong and should read:

The result should be:
{code}property.C=prefix \\value of id text-in-the-middle \\value of id suffix{code}

To get the expected result, the input would need to look like:
{code}property.double_escaped=prefix \${id} text-in-the-middle \${id} suffix{code}

Note: The filtering does not know about anything file format specific. Escaping the backslash
in a properties resource file is wrong here. The filtering does not know anything about any
file format specific escaping rules intentionally.


> escapeString doesn't work correctly for the 2nd filtering
> ---------------------------------------------------------
>
>                 Key: MASSEMBLY-756
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-756
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: filtering
>    Affects Versions: 2.5.3
>            Reporter: Vítor Moreira
>            Assignee: Olivier Lamy (*$^¨%`£)
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: escapeString.zip
>
>
> If we have a filter file with some escapeString, there are situations that escaping doesn't
work.
> For example, you have a filter file with two escaped filters:
> {code}property.double_escaped=prefix \\${id} text-in-the-middle \\${id} suffix{code}
> And that property is used in a config file, for example:
> {code}property.C=${property.double_escaped}{code}
> The result should be:
> {code}property.C=prefix ${id} text-in-the-middle ${id} suffix{code}
> And not this:
> {code}property.C=prefix ${id} text-in-the-middle \{id} suffix{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message