maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MDEP-481) <destFileName> is getting ignored
Date Thu, 08 Dec 2016 22:49:58 GMT

    [ https://issues.apache.org/jira/browse/MDEP-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733629#comment-15733629
] 

Robert Scholte commented on MDEP-481:
-------------------------------------

IIUC the {{destFileName}} refers to an actual file, never to a directory. In case of unpacking
it doesn't make sense to refer to a destFile, but only to an outputDirectory. {{ArtifactItem}}
is used for more goals, which might explain why the property is here, even though it is not
used in case of unpacking.

> <destFileName> is getting ignored
> ---------------------------------
>
>                 Key: MDEP-481
>                 URL: https://issues.apache.org/jira/browse/MDEP-481
>             Project: Maven Dependency Plugin
>          Issue Type: Bug
>          Components: unpack
>    Affects Versions: 2.10
>         Environment: Win 7 Pro SP1, 64 Bit, JDK 8u40
>            Reporter: Markus Karg
>
> With the following configuration, the entry <destFileName> is getting ignored,
but the original name as matched by the <includes> pattern is used for the destination
file name:
> {code:xml}<artifactItem>
> 	<groupId>g</groupId>
> 	<artifactId>a</artifactId>
> 	<type>t</type>
> 	<includes>prefix*suffix.ext</includes>
> 	<destFileName>name.ext</destFileName>
> </artifactItem>{code}
> This is problematic in case the exact file name is unknown or irrelevant, e. g. if a
file shall be picked by prefix solely, while the suffix (version, classifier, etc.) are irrelevant,
as the destFileName would leave out suffix anyways.
> As it is the POM author's responsibility to not overwrite files, the default behaviour
should not be to ignore <destFileName> in case of multiple pattern matches, but the
files should simply auto-overwrite each other. Typically the default use case where a POM
author would use patterns and destFileName at the same time, anyways is when he knows for
sure there is can be only one match.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message