maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Domagala (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MWAR-257) Remove deprecation of dependentWarExcludes, since there is no alternative on global level
Date Tue, 20 Dec 2016 09:38:58 GMT

    [ https://issues.apache.org/jira/browse/MWAR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763729#comment-15763729
] 

Michal Domagala edited comment on MWAR-257 at 12/20/16 9:38 AM:
----------------------------------------------------------------

Global level dependentWarExcludes/Includes are very useful and should be restored.

Global exclusion of {{WEB-INB/lib/*.jar}} is simple solution to problem [MWAR-33| https://issues.apache.org/jira/browse/MWAR-33]
(jars with differents versions can be in WEB-INF/lib with war as dependencies)

Unfortunately, commit https://fisheye6.atlassian.com/changelog/maven?cs=606628 for https://issues.apache.org/jira/browse/MWAR-118
marked {{dependentWarExcludes}} deprecated. I read issue description and I don't know why
it is deprecated. I think it was mistake or under analyzed change.

Finally, in maven-war-plugin version 3.0.0  {{dependentWarExcludes}} is removed. It has dramatic
impact on my application, which heavy use WAR customization implemented by war-extending-war.

My current setup for maven-war-plugin version 2.6 is global {{dependentWarExcludes=WEB-INF/lib/*.jar}}
and multiple WAR projects (for particular clients) depending on parent WARs. Just dependency,
nothing more.

If I switch to 3.0.0, I have to remove global {{dependentWarExcludes}} and for each WAR project,
beside dependency to parent WAR add section {{overlays}}, copy dependency data and add {{<excludes><exclude>WEB-INF/lib/*.jar</exclude></excludes>}}

I expect answer like:
1. It is stupid to have global configuration in root, better copy the same settings into multiple
child projects. (I will know I have to stay with 2.6)
2. It is cool to have global configuration, keep calm and wait for newer maven war plugin





was (Author: michaldo):
Global level dependentWarExcludes/Includes are very useful and should be restored.

That will be a long story...

Global exclusion of {{WEB-INB/lib/*.jar}} is simple solution to solve problem [MWAR-33| https://issues.apache.org/jira/browse/MWAR-33]
(jars with differents versions can be in WEB-INF/lib with war as dependencies)

Unfortunately, commit https://fisheye6.atlassian.com/changelog/maven?cs=606628 for https://issues.apache.org/jira/browse/MWAR-118
marked {{dependentWarExcludes}} deprecated. I read issue description and I don't know why
it is deprecated. I expected it was mistake or under analyzed change.



> Remove deprecation of dependentWarExcludes, since there is no alternative on global level
> -----------------------------------------------------------------------------------------
>
>                 Key: MWAR-257
>                 URL: https://issues.apache.org/jira/browse/MWAR-257
>             Project: Maven WAR Plugin
>          Issue Type: Bug
>          Components: overlay
>    Affects Versions: 2.1.1
>            Reporter: dool
>            Assignee: Michael Osipov
>             Fix For: 3.1.0
>
>
> Hello,
> DependentWarExcludes is marked as deprecated. Documentation says to use <overlay>/<excludes>
instead.
> But it seems to me that it is not possible to get the same behaviour with <overlay>/<excludes>
as in this case we have to provide groupIds and artifactIds.
> Maybe this behaviour could be reproduced when setting both groupId and artifactId to
* as below :
> <overlays>
> 	<overlay>
> 		<excludes>
> 			<groupId>*</groupId>
> 			<artifactId>*</artifactId>
> 			<exclude>**/*</exclude>
> 		</excludes>									
> 	</overlay>
> </overlays>
> By the way, I found this, by looking for a way to disable overlay. The workaround I thought
was configuring your plugin to exclude every files when overlaying.
> I think it would be nice to have a configuration parameter for that.
> Many thanks,
> Dool 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message