maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1311) JUnit47 provider should not internally parse JUnit Description
Date Fri, 02 Dec 2016 05:53:58 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714162#comment-15714162
] 

Hudson commented on SUREFIRE-1311:
----------------------------------

SUCCESS: Integrated in Jenkins build maven-surefire #1650 (See [https://builds.apache.org/job/maven-surefire/1650/])
[SUREFIRE-1311] JUnit47 provider should not internally parse JUnit (tibor17: rev d9b577cdc991d09116282d89ca69b5d2768acb0e)
* (edit) surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/JUnit46StackTraceWriter.java
* (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4RunListener.java
* (edit) surefire-providers/common-junit48/pom.xml
* (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4StackTraceWriter.java
* (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/NonConcurrentRunListener.java
* (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreRunListener.java


> JUnit47 provider should not internally parse JUnit Description
> --------------------------------------------------------------
>
>                 Key: SUREFIRE-1311
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1311
>             Project: Maven Surefire
>          Issue Type: Task
>          Components: Junit 4.7+ (parallel) support, Maven Failsafe Plugin, Maven Surefire
Plugin
>            Reporter: Tibor Digana
>            Assignee: Tibor Digana
>             Fix For: 2.19.2
>
>
> We used regex pattern to parse JUnit Description from string form to (className and methodName)
in provider {{surefire-junit4}}.
> The provider {{surefire-junit47}} inherited the same principle which is wrong because
JUnit 4.6 already has this parser inside and we should call {{Description.getClassName()}}
and {{Description.getMethodName()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message