maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Created] (MPLUGIN-321) fix documentation on maven-plugin-annotations that tells that provided is sufficient
Date Fri, 23 Dec 2016 07:13:58 GMT
Hervé Boutemy created MPLUGIN-321:
-------------------------------------

             Summary: fix documentation on maven-plugin-annotations that tells that provided
is sufficient
                 Key: MPLUGIN-321
                 URL: https://issues.apache.org/jira/browse/MPLUGIN-321
             Project: Maven Plugin Tools
          Issue Type: Bug
          Components: maven-plugin-annotations
    Affects Versions: 3.5
            Reporter: Hervé Boutemy
             Fix For: 3.5.1


https://maven.apache.org/plugin-tools-archives/plugin-tools-3.5/maven-plugin-plugin/examples/using-annotations.html#POM_configuration
tells
{code:xml}  <dependencies>
    <!-- dependencies to annotations -->
    <dependency>
      <groupId>org.apache.maven.plugin-tools</groupId>
      <artifactId>maven-plugin-annotations</artifactId>
      <version>3.5</version>
      <scope>provided</scope><!-- annotations are needed only to build the
plugin -->
    </dependency>
  </dependencies>
{code}

No, annotations are not needed only to build the plugin (since they have {{@Retention(value=CLASS)}}),
and Maven core does not inject maven-plugin-annotations at runtime (why would it? Maven core
works by reading {{META-INF/maven/plugin.xml}})

Maven Plugin Tools plugin itself was fixed in MPLUGIN-296, since a change in Maven core (MRESOLVER-8/MNG-6135)
plugin dependencies resolution showed that it was working magically but should not have worked
previously...

then our recipe have to be updated to avoid people continuing to introduce this wrong magic
in their plugins...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message