maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <>
Subject [jira] [Closed] (MNG-6025) Add a ProjectArtifactsCache similar to PluginArtifactsCache
Date Sun, 01 Jan 2017 01:16:58 GMT


Michael Osipov closed MNG-6025.
    Resolution: Fixed

Fixed with [7277a8464ba453aeacb82b22ffd966c9fb17c620|;a=commit;h=7277a8464ba453aeacb82b22ffd966c9fb17c620].

> Add a ProjectArtifactsCache similar to PluginArtifactsCache
> -----------------------------------------------------------
>                 Key: MNG-6025
>                 URL:
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.3.9
>            Reporter: Anton Tanasenko
>            Assignee: Jason van Zyl
>            Priority: Minor
>             Fix For: 3.4.0
> Every mojo execution, if it specifies dependency resolution other than 'none', will cause
a resolution to be performed.
> There is a guard in MojoExecutor's DependencyContext which guards against performing
this resolution multiple times by looking at the changes to dependencyArtifacts list.
> However, during a build in an incremental/interactive environment, like eclipse m2e or
maven console, those mojos might be executed at an arbitrary time and will not benefit from
that DependencyContext check.
> I propose having a ProjectArtifactsCache (very similar to PluginArtifactsCache) that
will cache artifact set as returned by LifecycleDependencyResolver#getDependencies().
> While it does not improve cli builds, incremental/interactive builds will receive a huge
performance boost between pom changes.
> I've been able to get build of a project with a lot of dependencies (jenkins plugin)
and a number of (fully incremental) mojo executions from 7 seconds to around 1.5 on a single
java file change in eclipse m2e after introducing this cache.
> I will provide a patch shortly.

This message was sent by Atlassian JIRA

View raw message