maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (MRELEASE-979) Support NamingPolicies to manage Branch and Tag names
Date Fri, 03 Mar 2017 01:07:45 GMT


ASF GitHub Bot commented on MRELEASE-979:

GitHub user hgschmie opened a pull request:

    MRELEASE-979 fixes 

    The proposed (and merged) change has the following problems (IAW it does not work at all):
    - The selected naming policy is not copied in all places; especially it is not copied
when merging with the properties loaded from the file. As a result, it
always reverts to 'default'
    - The current logic only executes the naming policy if the scmTagName is unset. This is
counter-intuitive (to say the least). My original proposed patch did not have that problem.
Change this to execute unconditionally if the operation requested is a branch operation, otherwise
only if the scmTagName is unset
    - The current logic failed unconditionally if the build is non-interactive and a branch
operation is requested. 
    This pull request fixes all of the mentioned problems. 

You can merge this pull request into a Git repository by running:

    $ git pull MRELEASE-979-fixes

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
commit 5b17a0e21d59170a905d2d8eea4d0cb7f3d3bb65
Author: Henning Schmiedehausen <>
Date:   2017-03-03T00:19:07Z

    Adds missing places where the naming policy id is not copied.

commit d505400d3cdc69d930e98c8287973e79e8be9756
Author: Henning Schmiedehausen <>
Date:   2017-03-03T00:20:04Z

    Fixes the naming policy logic.
    - Ensure that the naming policy is executed when a branch is requested even if an scm
tag name is set.
    - Ensure that in non-interactive mode, the plugin does not fail unconditionally if a branch
is requested.


> Support NamingPolicies to manage Branch and Tag names
> -----------------------------------------------------
>                 Key: MRELEASE-979
>                 URL:
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>          Components: branch, prepare, update-versions
>    Affects Versions: 2.5.3
>            Reporter: Henning Schmiedehausen
>             Fix For: 3.0.0
> The newly introduced VersionPolicy facility allows managing the development and release
versions of projects when releasing, branching and updating versions.
> Most organizations will also have a policy around how branches and tags are named (which
often have to match specific versioning patterns). The current VersionPolicy implementations
do not allow this but it should be possible.

This message was sent by Atlassian JIRA

View raw message