maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPOM-163) apache-rat-plugin exclude .checkstyle file created by Eclipse Checkstyle plugin
Date Wed, 22 Mar 2017 16:28:41 GMT

    [ https://issues.apache.org/jira/browse/MPOM-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936628#comment-15936628
] 

ASF GitHub Bot commented on MPOM-163:
-------------------------------------

GitHub user vorburger opened a pull request:

    https://github.com/apache/maven-pom/pull/3

    [MPOM-163] apache-rat-plugin exclude .checkstyle file

    This file is created by the Eclipse Checkstyle plugin
    <http://eclipse-cs.sourceforge.net> and is typically
    on .gitignore, so it should be ignored by RAT.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vorburger/maven-pom MPOM-163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-pom/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit 308eb32e39c53516990a73dca3fe207bd441b03c
Author: Michael Vorburger <vorburger@apache.org>
Date:   2017-03-22T16:25:00Z

    [MPOM-163] apache-rat-plugin exclude .checkstyle file
    
    This file is created by the Eclipse Checkstyle plugin
    <http://eclipse-cs.sourceforge.net> and is typically
    on .gitignore, so it should be ignored by RAT.

----


> apache-rat-plugin exclude .checkstyle file created by Eclipse Checkstyle plugin
> -------------------------------------------------------------------------------
>
>                 Key: MPOM-163
>                 URL: https://issues.apache.org/jira/browse/MPOM-163
>             Project: Maven POMs
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>
> I had trouble with the apache-rat-plugin enforced by the ASF Parent POM because it stumbled
upon and did not like the the .checkstyle files which by the Eclipse Checkstyle plugin (see
http://eclipse-cs.sourceforge.net) unfortunately creates at the root of every (Eclipse) project
(= artifact). 
> FYI: These .checkstyle are normally on .gitignore. (PS: What would be really cool would
be if the apache-rat-plugin was smart enough to ignore files that are in .gitignore...)
> Perhaps you'd be open to adding this file to the excludes of the apache-rat-plugin in
the ASF Parent POM?  I'll send you a pull request with a suggestion (if PR on GH are acceptable;
else plz clarify how to contribute; FYI am ASF member).
> In the mean time, it's easy enough to work around using {{-Drat.skip}} - once you understood
what it's not happy about.. ;-)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message